Differential D3706

storage: directory_: Type remaining existing endpoints
ClosedPublic
Actions

Authored by ardumont on Aug 4 2020, 11:12 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Maniphest Tasks

T2517: Add remaining missing types to swh.storage.interface

Commits

rDSTO9f214bc745ee: storage*: directory_entry_get_by_path: Type remaining existing endpoints
rDSTOf9d09527a6ba: storage*: directory_ls: Type remaining existing endpoints
rDSTOfd5fd86b11a8: storage*: directory_missing: Type remaining existing endpoints

Summary

endpoints:

directory_missing
directory_ls
directory_entry_get_by_path

Note: 3 commits related to directory endpoints in the diff

Related to T645

Test Plan

tox

Diff Detail

Repository

rDSTO Storage manager

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Aug 4 2020, 11:12 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptAug 4 2020, 11:12 PM

Build is green

Patch application report for D3706 (id=13045)

Could not rebase; Attempt merge onto a5232b7a7b...

Updating a5232b7a..9f214bc7
Fast-forward
 swh/storage/cassandra/storage.py |  82 ++++++++++++++---------
 swh/storage/filter.py            |  19 +++---
 swh/storage/in_memory.py         |  82 +++++++++++++++--------
 swh/storage/interface.py         | 137 ++++++++++++++++++++++-----------------
 swh/storage/storage.py           |  77 +++++++++++++---------
 5 files changed, 240 insertions(+), 157 deletions(-)

Changes applied before test

commit 9f214bc745ee666071384b47da8a2f6cc7ab65da
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 23:04:26 2020 +0200

    storage*: directory_entry_get_by_path: Type remaining existing endpoints
    
    Related to T645

commit f9d09527a6ba682c7cdb487de3538fb58fa8b346
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 22:35:45 2020 +0200

    storage*: directory_ls: Type remaining existing endpoints
    
    Related to T645

commit fd5fd86b11a8dafeb564a3d07624becf57d90672
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 22:27:45 2020 +0200

    storage*: directory_missing: Type remaining existing endpoints
    
    Related to T645

commit 5d13cd7c545141a632e6e60e485cdc33e451f4e2
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 22:07:34 2020 +0200

    storage*: skipped_content_missing: Type remaining existing endpoints
    
    Related to T645

commit 1a2aa70c687cbdac7655257ac3e6e572c8da43b4
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 18:57:37 2020 +0200

    storage*: content_missing_per_sha1_git: Type remaining existing endpoints
    
    Related to T645

commit 15e48633a6a7beeccd233a38cdd456070fb4ae07
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 18:55:39 2020 +0200

    storage*: content_missing_per_sha1: Type remaining existing endpoints
    
    Related to T645

commit b62afbbbdd95aaa91163c8907fa7237231d7c3a6
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 18:13:43 2020 +0200

    storage*: content_missing: Unify and type remaining existing endpoints
    
    This updates the docstrings as well
    
    Related to T645

commit d6f26e45e9a62894ab2b888a15f8a4417c3b2ce0
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 18:06:06 2020 +0200

    storage*: content_get_partition: Type remaining existing endpoints
    
    Related to T645

commit 864473370acdfd5acaf9afbfea9d16745b3c102f
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 17:56:39 2020 +0200

    storage*: content_get_range: Type remaining existing endpoints
    
    Related to T645

commit c6da28289ec4f1be1eb1c1e78d561b8cc8dac937
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 17:45:31 2020 +0200

    storage*: content_get: Type remaining existing endpoints
    
    Related to T645

commit 25ebc48198d665cc3bb71c96a8ae54775ddf38a8
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 17:42:12 2020 +0200

    storage*: content_update: Type remaining existing endpoints
    
    Related to T645

commit c32e224d23996705a6ca969696cc4715598ed796
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 17:59:46 2020 +0200

    storage*: origin_get_by_sha1: Type remaining existing endpoints
    
    Related to T645

commit 26ef01563f058bdfe77fcf5d2ca6a897e2894bc8
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 17:59:24 2020 +0200

    storage*: check_config: Type remaining existing endpoints
    
    Related to T645

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/682/ for more details.

Harbormaster completed remote builds in B14288: Diff 13045.Aug 4 2020, 11:20 PM

ardumont edited the summary of this revision. (Show Details)Aug 5 2020, 8:06 AM

ardumont edited the summary of this revision. (Show Details)Aug 5 2020, 8:38 AM

vlorentz accepted this revision.Aug 5 2020, 9:03 AM

This revision is now accepted and ready to land.Aug 5 2020, 9:03 AM

Closed by commit rDSTOfd5fd86b11a8: storage*: directory_missing: Type remaining existing endpoints (authored by ardumont). · Explain WhyAug 5 2020, 11:55 AM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDSTOfd5fd86b11a8: storage*: directory_missing: Type remaining existing endpoints.

ardumont added a commit: rDSTOf9d09527a6ba: storage*: directory_ls: Type remaining existing endpoints.

ardumont added a commit: rDSTO9f214bc745ee: storage*: directory_entry_get_by_path: Type remaining existing endpoints.

ardumont added a task: T2517: Add remaining missing types to swh.storage.interface.Aug 5 2020, 1:12 PM