Differential D3699

storage*: content_update: Type remaining existing endpoints
ClosedPublic
Actions

Authored by ardumont on Aug 4 2020, 6:40 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Maniphest Tasks

T2517: Add remaining missing types to swh.storage.interface

Commits

rDSTO25ebc48198d6: storage*: content_update: Type remaining existing endpoints

Summary

Related to T645

Test Plan

tox

Diff Detail

Repository

rDSTO Storage manager

Branch

master

Lint

Lint Skipped

Unit

Unit Tests Skipped

Build Status

Buildable 14283
Build 21967: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 21966: arc lint + arc unit

Event Timeline

ardumont created this revision.Aug 4 2020, 6:40 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptAug 4 2020, 6:40 PM

Build has FAILED

Patch application report for D3699 (id=13031)

Could not rebase; Attempt merge onto a5232b7a7b...

Updating a5232b7a..2925f717
Fast-forward
 swh/storage/cassandra/storage.py | 16 +++++++++-------
 swh/storage/in_memory.py         | 15 +++++++++------
 swh/storage/interface.py         | 20 +++++++++++---------
 swh/storage/storage.py           | 14 +++++++++-----
 4 files changed, 38 insertions(+), 27 deletions(-)

Changes applied before test

commit 2925f7176a0f6ede8242c6507a69a00ce313cca2
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 17:42:12 2020 +0200

    storage*: content_update: Type remaining existing endpoints
    
    Related to T645

commit c32e224d23996705a6ca969696cc4715598ed796
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 17:59:46 2020 +0200

    storage*: origin_get_by_sha1: Type remaining existing endpoints
    
    Related to T645

commit 26ef01563f058bdfe77fcf5d2ca6a897e2894bc8
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 17:59:24 2020 +0200

    storage*: check_config: Type remaining existing endpoints
    
    Related to T645

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/668/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/668/console

Harbormaster failed remote builds in B14274: Diff 13031!Aug 4 2020, 6:48 PM

Fix

Build is green

Patch application report for D3699 (id=13040)

Could not rebase; Attempt merge onto a5232b7a7b...

Updating a5232b7a..25ebc481
Fast-forward
 swh/storage/cassandra/storage.py | 16 +++++++++-------
 swh/storage/in_memory.py         | 17 +++++++++++------
 swh/storage/interface.py         | 20 +++++++++++---------
 swh/storage/storage.py           | 14 +++++++++-----
 4 files changed, 40 insertions(+), 27 deletions(-)

Changes applied before test

commit 25ebc48198d665cc3bb71c96a8ae54775ddf38a8
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 17:42:12 2020 +0200

    storage*: content_update: Type remaining existing endpoints
    
    Related to T645

commit c32e224d23996705a6ca969696cc4715598ed796
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 17:59:46 2020 +0200

    storage*: origin_get_by_sha1: Type remaining existing endpoints
    
    Related to T645

commit 26ef01563f058bdfe77fcf5d2ca6a897e2894bc8
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 17:59:24 2020 +0200

    storage*: check_config: Type remaining existing endpoints
    
    Related to T645

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/677/ for more details.

Harbormaster completed remote builds in B14283: Diff 13040.Aug 4 2020, 9:56 PM

vlorentz accepted this revision.Aug 5 2020, 8:54 AM

This revision is now accepted and ready to land.Aug 5 2020, 8:54 AM

Closed by commit rDSTO25ebc48198d6: storage*: content_update: Type remaining existing endpoints (authored by ardumont). · Explain WhyAug 5 2020, 11:17 AM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDSTO25ebc48198d6: storage*: content_update: Type remaining existing endpoints.

ardumont added a task: T2517: Add remaining missing types to swh.storage.interface.Aug 5 2020, 1:12 PM

ardumont removed a task: T645: Type swh-storage endpoints with swh.model objects.