Page MenuHomeSoftware Heritage
Differential D3674

npm: Load the content of the API's response as extrinsic snapshot metadata.
ClosedPublic
Actions

Authored by vlorentz on Jul 31 2020, 3:46 PM.

Details

Reviewers
douardda
Group Reviewers
Reviewers
Maniphest Tasks
T2512: Make all loaders write their extrinsic metadata to the appropriate storage
Commits
rDLDBASE61aea4a2c173: npm: Load the content of the API's response as extrinsic snapshot metadata.

Diff Detail

Unit TestsFailed
View All

TimeTest
654 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.loader.package.npm.tests.test_npm::test_npm_loader_first_visit
swh_config = '/tmp/pytest-of-jenkins/pytest-0/test_npm_loader_first_visit0/loader.yml' requests_mock_datadir = <requests_mock.mocker.Mocker object at 0x7f165b4981d0> org_api_info = b'{\n "_id": "org",\n "_rev": "4-22484cc537f12d3023241211ee34e39d",\n "name": "org",\n "description": "A parser an...rser"\n ],\n "bugs": {\n "url": "http://github.com/mooz/org-s/issues"\n },\n "readmeFilename": "README.md"\n}\n'
2 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.loader.core.tests.test_converters::test_content_for_storage_data
7 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.loader.core.tests.test_converters::test_content_for_storage_path
3 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.loader.core.tests.test_converters::test_content_for_storage_too_long
2 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.loader.core.tests.test_converters::test_prepare_contents
View Full Test Results (1 Failed · 141 Passed)

Event Timeline

vlorentz created this revision.Jul 31 2020, 3:46 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptJul 31 2020, 3:46 PM
swh-public-ci added a comment.Jul 31 2020, 3:51 PM

Build is green

Patch application report for D3674 (id=12929)

Rebasing onto c510d10d23...

Current branch diff-target is up to date.
Changes applied before test
commit deb38d7fdd1fdb1c9ac476f6ca72cf492b0503aa
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Jul 31 15:44:32 2020 +0200

    npm: Load the content of the API's response as extrinsic snapshot metadata.

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/238/ for more details.

Harbormaster completed remote builds in B14167: Diff 12929.Jul 31 2020, 3:52 PM
vlorentz added a child revision: D3676: Add a default value for RawExtrinsicMetadataCore.discovery_date.Jul 31 2020, 4:36 PM
vlorentz added a task: T2512: Make all loaders write their extrinsic metadata to the appropriate storage.Jul 31 2020, 4:38 PM
douardda accepted this revision.Jul 31 2020, 5:22 PM
douardda added a subscriber: douardda.

as discussed on IRC, I'm not feeling very comfortable with the format stuff (in RawExtrinsicMetadataCore) but meh.

This revision is now accepted and ready to land.Jul 31 2020, 5:22 PM
vlorentz updated this revision to Diff 12940.Jul 31 2020, 6:51 PM

better authority url

vlorentz updated this revision to Diff 12945.Jul 31 2020, 6:52 PM

fix base commit

swh-public-ci added a comment.Jul 31 2020, 6:54 PM

Build has FAILED

Patch application report for D3674 (id=12940)

Rebasing onto c510d10d23...

Current branch diff-target is up to date.
Changes applied before test
commit 0ee6220db1dbff44a62a058281690b1f1d2c5282
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Jul 31 15:44:32 2020 +0200

    npm: Load the content of the API's response as extrinsic snapshot metadata.

Link to build: https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/244/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/244/console

Harbormaster failed remote builds in B14178: Diff 12940!Jul 31 2020, 6:54 PM
vlorentz updated this revision to Diff 12950.Jul 31 2020, 7:00 PM

fix test (this hunk was erroneously committed to D3679 instead)

vlorentz mentioned this in D3679: Convert the 'metadata' and 'info' cached-properties/lazy-attributes into methods..Jul 31 2020, 7:01 PM
swh-public-ci added a comment.Jul 31 2020, 7:03 PM

Build is green

Patch application report for D3674 (id=12950)

Rebasing onto c510d10d23...

Current branch diff-target is up to date.
Changes applied before test
commit 61aea4a2c1731f118b58ccd2d45225d64518d2bf
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Jul 31 15:44:32 2020 +0200

    npm: Load the content of the API's response as extrinsic snapshot metadata.

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/247/ for more details.

Harbormaster completed remote builds in B14188: Diff 12950.Jul 31 2020, 7:03 PM
Closed by commit rDLDBASE61aea4a2c173: npm: Load the content of the API's response as extrinsic snapshot metadata. (authored by vlorentz). · Explain WhyJul 31 2020, 7:13 PM
This revision was automatically updated to reflect the committed changes.
vlorentz added a commit: rDLDBASE61aea4a2c173: npm: Load the content of the API's response as extrinsic snapshot metadata..

Revision Contents
Changeset List

PathSize
swh/
loader/
package/
npm/
25 lines
tests/
52 lines

Diff 12940

View Options

swh/loader/package/npm/loader.py

Loading...
View Options

swh/loader/package/npm/tests/test_npm.py

Loading...
About · Developer information · Legal