Page MenuHomeSoftware Heritage
Differential D3675

origin: Migrate use to storage.origin_list instead of origin_get_range
ClosedPublic
Actions

Authored by ardumont on Jul 31 2020, 4:19 PM.

Details

Reviewers
vlorentz
Group Reviewers
Reviewers
Maniphest Tasks
T2214: Scale-out graph and database storage in production
T645: Type swh-storage endpoints with swh.model objects
Commits
rDWAPPSb19fb3f661fe: origin: Migrate use to storage.origin_list instead of origin_get_range
Summary

The origin-get-range endpoint will be dropped from the storage.

Note: This will actually make it possible to use the webapp with cassandra now for that part
(cassandra storage does not expose the origin-get-range endpoint).

Related to T645
Related to T2214

Test Plan

tox

Diff Detail

Repository
rDWAPPS Web applications
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 14171
Build 21772: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 21771: arc lint + arc unit

Event Timeline

ardumont created this revision.Jul 31 2020, 4:19 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptJul 31 2020, 4:19 PM
ardumont edited the summary of this revision. (Show Details)Jul 31 2020, 4:25 PM
vlorentz requested changes to this revision.Jul 31 2020, 4:30 PM
vlorentz added a subscriber: vlorentz.
vlorentz added inline comments.
swh/web/api/views/origin.py
89–107

change the name of the parameter.

also raise an error if the old name is passed, so clients who still use it get a proper error

110

here too

swh/web/common/service.py
251–252

-> PagedResultInfo[OriginInfo]

This revision now requires changes to proceed.Jul 31 2020, 4:30 PM
ardumont added inline comments.Jul 31 2020, 4:30 PM
swh/web/api/views/origin.py
89

Kept origin-from and origin-count which are exposed as is.

swh/web/common/service.py
251–252

yes, fixed locally already, i waited for the build to finish.

swh-public-ci added a comment.Jul 31 2020, 4:31 PM

Build is green

Patch application report for D3675 (id=12931)

Rebasing onto ddfb658d25...

Current branch diff-target is up to date.
Changes applied before test
commit a28dd1bd54421e7b1e317b406f3c332bdf532c9e
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jul 31 16:17:53 2020 +0200

    origin: Migrate use to storage.origin_list instead of origin_get_range
    
    Related to T645

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/289/ for more details.

Harbormaster completed remote builds in B14169: Diff 12931.Jul 31 2020, 4:31 PM
vlorentz added inline comments.Jul 31 2020, 4:35 PM
swh/web/api/views/origin.py
89

I know, but we should change the name of origin_from because its semantics changed.

ardumont updated this revision to Diff 12933.Jul 31 2020, 4:47 PM

Adapt according to review:

  • rename query parameters
  • fail with a 400 and an explanatory message when old query parameters are used
  • Add tests around those use cases
swh/web/api/views/origin.py
89

oh yeah, said that prior to you asking me to change

I agree, was unsure on how to proceed ;)

swh-public-ci added a comment.Jul 31 2020, 4:59 PM

Build is green

Patch application report for D3675 (id=12933)

Rebasing onto ddfb658d25...

Current branch diff-target is up to date.
Changes applied before test
commit 7f930c261f4a14a813e39c49a89280e2f8b58cbf
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jul 31 16:17:53 2020 +0200

    origin: Migrate use to storage.origin_list instead of origin_get_range
    
    Related to T645

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/290/ for more details.

Harbormaster completed remote builds in B14171: Diff 12933.Jul 31 2020, 4:59 PM
vlorentz added a comment.Jul 31 2020, 5:11 PM

I don't see any reason to change the name of origin_count, I think we should keep it

ardumont added a comment.Jul 31 2020, 5:22 PM

i misunderstood

ardumont updated this revision to Diff 12935.Jul 31 2020, 5:22 PM

Keep origin_count parameter name

vlorentz added inline comments.Jul 31 2020, 5:28 PM
swh/web/api/views/origin.py
68–72

forgot to undo this change

swh-public-ci added a comment.Jul 31 2020, 5:34 PM

Build is green

Patch application report for D3675 (id=12935)

Rebasing onto ddfb658d25...

Current branch diff-target is up to date.
Changes applied before test
commit de3d682e268d00c0cdc5059ff04d713b58796f63
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jul 31 16:17:53 2020 +0200

    origin: Migrate use to storage.origin_list instead of origin_get_range
    
    Related to T645

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/291/ for more details.

Harbormaster completed remote builds in B14173: Diff 12935.Jul 31 2020, 5:34 PM
ardumont updated this revision to Diff 12936.Jul 31 2020, 5:38 PM

Revert limit mention in docstring

swh-public-ci added a comment.Jul 31 2020, 5:50 PM

Build has FAILED

Patch application report for D3675 (id=12936)

Rebasing onto ddfb658d25...

Current branch diff-target is up to date.
Changes applied before test
commit e543cfdf56c19755b0d82f15b9e9a154ecd10f9f
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jul 31 16:17:53 2020 +0200

    origin: Migrate use to storage.origin_list instead of origin_get_range
    
    Related to T645

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/292/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/292/console

Harbormaster failed remote builds in B14174: Diff 12936!Jul 31 2020, 5:50 PM
swh-public-ci added a comment.Jul 31 2020, 6:09 PM

Build is green

Patch application report for D3675 (id=12936)

Rebasing onto ddfb658d25...

Current branch diff-target is up to date.
Changes applied before test
commit e543cfdf56c19755b0d82f15b9e9a154ecd10f9f
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jul 31 16:17:53 2020 +0200

    origin: Migrate use to storage.origin_list instead of origin_get_range
    
    Related to T645

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/293/ for more details.

Harbormaster completed remote builds in B14174: Diff 12936.Jul 31 2020, 6:09 PM
vlorentz added inline comments.Jul 31 2020, 10:52 PM
swh/web/api/views/origin.py
86–87

this one too (sorry)

91

The error message should say to use the Link header. page_token is not part of the API and users shouldn't are about it, as explained in the docstring

ardumont added inline comments.Aug 1 2020, 9:25 AM
swh/web/api/views/origin.py
86–87

don't be, that's fine

it's on me, i looked but fail to see it ;)

91

right.

ardumont updated this revision to Diff 12960.Aug 1 2020, 9:25 AM

Adapt according to last good remarks:

  • fix missing revert on docstring
  • Explicit the 400 error message when api is misused
ardumont mentioned this in D3681: storage*: Drop origin-get-range in favor of origin-list.Aug 1 2020, 9:30 AM
swh-public-ci added a comment.Aug 1 2020, 9:36 AM

Build is green

Patch application report for D3675 (id=12960)

Rebasing onto ddfb658d25...

Current branch diff-target is up to date.
Changes applied before test
commit b19fb3f661fe5b4cd786dd3af68fa6e883a9a10d
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jul 31 16:17:53 2020 +0200

    origin: Migrate use to storage.origin_list instead of origin_get_range
    
    Related to T645

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/294/ for more details.

Harbormaster completed remote builds in B14198: Diff 12960.Aug 1 2020, 9:36 AM
ardumont edited the summary of this revision. (Show Details)Aug 2 2020, 11:17 AM
ardumont added a task: T2214: Scale-out graph and database storage in production.
vlorentz accepted this revision.Aug 3 2020, 9:07 AM
This revision is now accepted and ready to land.Aug 3 2020, 9:07 AM
Closed by commit rDWAPPSb19fb3f661fe: origin: Migrate use to storage.origin_list instead of origin_get_range (authored by ardumont). · Explain WhyAug 3 2020, 9:49 AM
This revision was automatically updated to reflect the committed changes.
ardumont added a commit: rDWAPPSb19fb3f661fe: origin: Migrate use to storage.origin_list instead of origin_get_range.

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
swh/
web/
api/
views/
46 lines100%
Loading...
common/
23 lines91%
Loading...
10 lines100%
Loading...
tests/
api/
views/
45 lines99%
Loading...

Diff 12933

View Options

swh/web/api/views/origin.py

Loading...
View Options

swh/web/common/service.py

Loading...
View Options

swh/web/common/typing.py

Loading...
View Options

swh/web/tests/api/views/test_origin.py

Loading...
About · Developer information · Legal