Make the previously loaded artifacts a list rather than an iterator
ClosedPublic
Actions

Authored by olasd on Sep 18 2018, 2:47 PM.

Details

Reviewers

ardumont

Commits

rDLDPY37f88b2bde0d: Make the previously loaded artifacts a list rather than an iterator

Summary

That's needed as we check its contents once per version referenced in the list
of upstream releases.

Test Plan

Running the loader twice on the same module now only loads each artifact once

Diff Detail

Repository

rDLDPY PyPI loader

Branch

bugfix/incremental-load

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 1397
Build 1741: arc lint + arc unit

Event Timeline

olasd created this revision.Sep 18 2018, 2:47 PM

Harbormaster completed remote builds in B1397: Diff 1288.Sep 18 2018, 2:47 PM

Running the loader twice on the same module now only loads each artifact once

I thought i tested that though [1]

https://forge.softwareheritage.org/source/swh-loader-pypi/browse/master/swh/loader/pypi/tests/test_loader.py$228

swh/loader/pypi/loader.py
113	Not a blocker. That should always be the case here. `fetch_data` builds the revision that way.

This revision is now accepted and ready to land.Sep 18 2018, 3:00 PM

olasd added a child revision: D414: Reorder imports in the "standard" order.Sep 18 2018, 3:17 PM

Closed by commit rDLDPY37f88b2bde0d: Make the previously loaded artifacts a list rather than an iterator (authored by olasd). · Explain WhySep 19 2018, 11:31 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

swh/

loader/

pypi/

loader.py

9 lines

Diff 1288

View Options

Make the previously loaded artifacts a list rather than an iteratorClosedPublicActions