Differential D3617

Drop unsupported "validate" proxy
ClosedPublic
Actions

Authored by ardumont on Jul 24 2020, 5:58 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Maniphest Tasks

T2499: Drop the storage validate proxy used only in tests

Commits

rDCIDXc5352caf01fc: Drop unsupported "validate" proxy

Summary

Fix jenkins build broken since the storage no longer supports the validate proxy [1]

[1] https://jenkins.softwareheritage.org/job/DCIDX/job/tests/1063/console

Related to T2499

Test Plan

tox

Diff Detail

Repository

rDCIDX Metadata indexer

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 13952
Build 21412: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 21411: arc lint + arc unit

Event Timeline

ardumont created this revision.Jul 24 2020, 5:58 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJul 24 2020, 5:58 PM

ardumont planned changes to this revision.Jul 24 2020, 5:58 PM

Build has FAILED

Patch application report for D3617 (id=12724)

Rebasing onto f0c264d3a6...

Current branch diff-target is up to date.

Changes applied before test

commit ef702dc954ee8fe0c8bed50943b3e722491f96e3
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jul 24 17:57:05 2020 +0200

    wip: Drop unsupported "validate" proxy
    
    This should fix [1] when finished
    
    [1] https://jenkins.softwareheritage.org/job/DCIDX/job/tests/1063/console

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/25/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/25/console

Harbormaster failed remote builds in B13950: Diff 12724!Jul 24 2020, 6:00 PM

ardumont edited the summary of this revision. (Show Details)Jul 24 2020, 6:00 PM

vlorentz accepted this revision.Jul 24 2020, 6:10 PM

Fix last tests

The remaining issue was because I changed to using real data. Doing so, I
changed a "join" which made the tests not happy.

This revision is now accepted and ready to land.Jul 25 2020, 7:54 AM

ardumont retitled this revision from wip: Drop unsupported "validate" proxy to Drop unsupported "validate" proxy.Jul 25 2020, 7:54 AM

ardumont edited the summary of this revision. (Show Details)

ardumont edited the test plan for this revision. (Show Details)

ardumont added a task: T2499: Drop the storage validate proxy used only in tests.

Build is green

Patch application report for D3617 (id=12726)

Rebasing onto f0c264d3a6...

Current branch diff-target is up to date.

Changes applied before test

commit c5352caf01fc13187c9176aa4f43b7e5a5a88a36
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jul 24 17:57:05 2020 +0200

    Drop unsupported "validate" proxy
    
    This should fix [1] when finished
    
    [1] https://jenkins.softwareheritage.org/job/DCIDX/job/tests/1063/console
    
    Related to T2499

See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/26/ for more details.

Harbormaster completed remote builds in B13952: Diff 12726.Jul 25 2020, 7:56 AM

ardumont edited the summary of this revision. (Show Details)Jul 25 2020, 7:57 AM

Closed by commit rDCIDXc5352caf01fc: Drop unsupported "validate" proxy (authored by ardumont). · Explain WhyJul 25 2020, 8:01 AM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDCIDXc5352caf01fc: Drop unsupported "validate" proxy.