Differential D3610

metadata_{authority,fetcher}_add: Fix crash when the iterable argument is empty.
ClosedPublic
Actions

Authored by vlorentz on Jul 24 2020, 9:28 AM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDSTO789972fd5fa2: metadata_{authority,fetcher}_add: Fix crash when the iterable argument is empty.

Diff Detail

Repository

rDSTO Storage manager

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 13934
Build 21381: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 21380: arc lint + arc unit

Event Timeline

vlorentz created this revision.Jul 24 2020, 9:28 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptJul 24 2020, 9:28 AM

ardumont accepted this revision.Jul 24 2020, 9:31 AM

This revision is now accepted and ready to land.Jul 24 2020, 9:31 AM

Build is green

Patch application report for D3610 (id=12708)

Rebasing onto 7e94767a51...

Current branch diff-target is up to date.

Changes applied before test

commit 789972fd5fa273878beeeeef17551485940eb842
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Jul 24 09:28:33 2020 +0200

    metadata_{authority,fetcher}_add: Fix crash when the iterable argument is empty.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/559/ for more details.

Harbormaster completed remote builds in B13934: Diff 12708.Jul 24 2020, 9:36 AM

Closed by commit rDSTO789972fd5fa2: metadata_{authority,fetcher}_add: Fix crash when the iterable argument is empty. (authored by vlorentz). · Explain WhyJul 24 2020, 2:05 PM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDSTO789972fd5fa2: metadata_{authority,fetcher}_add: Fix crash when the iterable argument is empty..

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

swh/

storage/

storage.py

12 lines

94%

tests/

test_storage.py

17 lines

99%

Diff 12708

View Options

swh/storage/storage.py