swh-core fixes to allow debian build
ClosedPublic
Actions

Authored by ardumont on Jul 8 2020, 12:59 PM.

Details

Reviewers

None

Group Reviewers

Commits

rDCORE84c7319bc37a: api.tests: Fix unsupported matches keyword to match
rDCOREfc429c6ea6d0: requirements-db: Move typing-extension from test to runtime deps

Summary

requirements-db: Move typing-extension from test to runtime deps (to match [1])
api.tests: Fix unsupported matches keyword to match [3]

Not necessarily for review, just making sure tox is happy

[1] rDCOREc8a36cefa472eb6dbbfe04289a8f69ea99eab01f which fixed [2]

[2] https://jenkins.softwareheritage.org/view/Debian%20packages/job/debian/job/packages/job/DCORE/job/gbp-buildpackage/117/console

[3] current debian build in failure with P719

Test Plan

tox

Diff Detail

Repository

rDCORE Foundations and core functionalities

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Jul 8 2020, 12:59 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJul 8 2020, 12:59 PM

ardumont edited the summary of this revision. (Show Details)Jul 8 2020, 1:00 PM

Build is green

Patch application report for D3459 (id=12243)

Rebasing onto ce1e452383...

Current branch diff-target is up to date.

Changes applied before test

commit 84c7319bc37abb5fd97af994a9527ae01218ee44
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Jul 8 12:55:25 2020 +0200

    api.tests: Fix unsupported matches keyword to match
    
    This fixes the debian build yet to come

commit fc429c6ea6d064e53ec6c4dab91b2dd35db75280
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Jul 8 12:54:58 2020 +0200

    requirements-db: Move typing-extension from test to runtime deps

See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/18/ for more details.

Harbormaster completed remote builds in B13462: Diff 12243.Jul 8 2020, 1:01 PM

ardumont edited the summary of this revision. (Show Details)Jul 8 2020, 1:01 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jul 8 2020, 1:03 PM

Closed by commit rDCOREfc429c6ea6d0: requirements-db: Move typing-extension from test to runtime deps (authored by ardumont). · Explain Why

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDCOREfc429c6ea6d0: requirements-db: Move typing-extension from test to runtime deps.

ardumont added a commit: rDCORE84c7319bc37a: api.tests: Fix unsupported matches keyword to match.

ardumont mentioned this in D3460: test_serializers: Move to pytest for that specific erratic assertion.Jul 8 2020, 1:15 PM