Differential D3362

indexer*: Drop obsolete origin visit fields
ClosedPublic
Actions

Authored by ardumont on Jun 26 2020, 10:25 AM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Maniphest Tasks

T2310: Make origin visits immutable

Commits

rDCIDXa40fc83df742: tests: Drop obsolete origin visit fields

Summary

Related to T2310

Test Plan

tox

Diff Detail

Repository

rDSTO Storage manager

Branch

add-limit-to-snapshot-get-latest

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 13143
Build 20058: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 20057: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	819 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.storage.tests.test_storage.TestStorageGeneratedData::test_origin_list[1] swh_storage = <swh.storage.validate.ValidatingProxyStorage object at 0x7f1b925f92b0> @pytest.fixture
	4 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.storage.fixer::swh.storage.fixer._fix_content
	2 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.storage.fixer::swh.storage.fixer._fix_origin
	4 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.storage.fixer::swh.storage.fixer._fix_origin_visit
	4 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.storage.fixer::swh.storage.fixer._fix_revision
		View Full Test Results (1 Failed · 751 Passed · 17 Skipped)

Event Timeline

ardumont created this revision.Jun 26 2020, 10:25 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptJun 26 2020, 10:25 AM

Build has FAILED

Patch application report for D3362 (id=11916)

Rebasing onto a8307fccb4...

Current branch diff-target is up to date.

Changes applied before test

commit 336e409eb0583e0ab7882029fdfe2f1e1ae9773c
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jun 26 10:21:30 2020 +0200

    indexer*: Drop origin visit obsolete fields
    
    Related to T2310

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/19/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/19/console

Harbormaster failed remote builds in B13131: Diff 11916!Jun 26 2020, 10:25 AM

ardumont mentioned this in T2310: Make origin visits immutable.Jun 26 2020, 10:26 AM

ardumont retitled this revision from indexer*: Drop origin visit obsolete fields to indexer*: Drop obsolete origin visit fields.Jun 26 2020, 10:33 AM

the commit message should mention the changes are in tests

This revision is now accepted and ready to land.Jun 26 2020, 1:04 PM

Rework commit message to mention only tests are impacted

Use the correct repository to update the diff is better...

Build has FAILED

Patch application report for D3362 (id=11929)

Rebasing onto a8307fccb4...

Current branch diff-target is up to date.

Changes applied before test

commit a40fc83df74222b026fc0ad9c6eec26831385909
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jun 26 10:21:30 2020 +0200

    tests: Drop obsolete origin visit fields
    
    Related to T2310

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/20/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/20/console

Harbormaster failed remote builds in B13144: Diff 11929!Jun 26 2020, 1:14 PM

Build has FAILED

Patch application report for D3362 (id=11928)

Could not rebase; Attempt merge onto f75cd41ab8...

Updating f75cd41a..2a56db1b
Fast-forward
 swh/storage/algos/origin.py              |  5 +-
 swh/storage/algos/snapshot.py            |  8 ++-
 swh/storage/cassandra/cql.py             | 93 ++++++++++++++++++++++++++++----
 swh/storage/cassandra/storage.py         |  9 +++-
 swh/storage/db.py                        | 45 +++++++++-------
 swh/storage/in_memory.py                 | 15 ++++--
 swh/storage/interface.py                 |  7 ++-
 swh/storage/storage.py                   |  4 +-
 swh/storage/tests/algos/test_origin.py   |  7 +++
 swh/storage/tests/algos/test_snapshot.py | 21 +++-----
 swh/storage/tests/test_storage.py        | 39 +++++++++++++-
 11 files changed, 196 insertions(+), 57 deletions(-)

Changes applied before test

commit 2a56db1b1b31f055b53705a8cf0914de6894d451
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Jun 25 18:37:18 2020 +0200

    storage: Limit the *-get-latest functions search
    
    Impacts functions:
    - snapshot-get-latest
    - origin-get-latest-visit-status

commit 3b1695b2e7b1f5e227410b41953921e5a5806554
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Jun 24 18:04:29 2020 +0200

    storage*: Open order parameter to origin-visit-get endpoint
    
    This allows clients to search from most recent to oldest visit when calling the
    endpoint with the "order" parameter set to "desc" (visit id desc).
    
    This keeps and explicits the existing sorting order as visit id "asc".
    
    Related to T2310

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/375/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/375/console

Harbormaster failed remote builds in B13143: Diff 11928!Jun 26 2020, 1:15 PM

Build is green

Patch application report for D3362 (id=11929)

Rebasing onto a8307fccb4...

Current branch diff-target is up to date.

Changes applied before test

commit a40fc83df74222b026fc0ad9c6eec26831385909
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jun 26 10:21:30 2020 +0200

    tests: Drop obsolete origin visit fields
    
    Related to T2310

See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/21/ for more details.

Harbormaster completed remote builds in B13144: Diff 11929.Jun 29 2020, 10:06 AM

ardumont edited the test plan for this revision. (Show Details)Jun 29 2020, 10:18 AM

Closed by commit rDCIDXa40fc83df742: tests: Drop obsolete origin visit fields (authored by ardumont). · Explain WhyJun 29 2020, 10:19 AM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDCIDXa40fc83df742: tests: Drop obsolete origin visit fields.