Differential D3340

model.OriginVisit: Make obsolete fields optional
ClosedPublic
Actions

Authored by ardumont on Jun 23 2020, 5:32 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Maniphest Tasks

T2310: Make origin visits immutable

Commits

rDMOD636f8c2aa404: model.OriginVisit: Make obsolete fields optional

Summary

In order to smoothly transition to origin visit without those fields, let's
make them optional first.

Then we'll be able to drop them as D3337 suggests without breaking the world.

Related to T2310

Test Plan

tox

Diff Detail

Repository

rDMOD Data model

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 13063
Build 19918: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 19917: arc lint + arc unit

Event Timeline

ardumont created this revision.Jun 23 2020, 5:32 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJun 23 2020, 5:32 PM

Build is green

Patch application report for D3340 (id=11848)

Rebasing onto f349bdc628...

Current branch diff-target is up to date.

Changes applied before test

commit 636f8c2aa40419045908a537a647d22fc368533c
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Jun 23 17:29:53 2020 +0200

    model.OriginVisit: Make obsolete fields optional
    
    Related to T2310

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/77/ for more details.

Harbormaster completed remote builds in B13063: Diff 11848.Jun 23 2020, 5:33 PM

vlorentz accepted this revision.Jun 24 2020, 10:13 AM

This revision is now accepted and ready to land.Jun 24 2020, 10:13 AM

Closed by commit rDMOD636f8c2aa404: model.OriginVisit: Make obsolete fields optional (authored by ardumont). · Explain WhyJun 24 2020, 10:42 AM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDMOD636f8c2aa404: model.OriginVisit: Make obsolete fields optional.

ardumont mentioned this in D3344: journal_data: Make origin-visit optional fields to None.Jun 24 2020, 2:31 PM

ardumont mentioned this in rDJNL4c7d945492a7: journal_data: Make origin-visit optional fields to None.Jun 25 2020, 9:29 AM

ardumont mentioned this in T2310: Make origin visits immutable.Jun 25 2020, 7:21 PM

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

swh/

model/

hypothesis_strategies.py

4 lines

95%

model.py

11 lines

96%

Diff 11848

View Options

swh/model/hypothesis_strategies.py