Page MenuHomeSoftware Heritage
Differential D3018

Drop BWCompatInMemoryJournalWriter (released with swh.journal 0.0.30)
ClosedPublic
Actions

Authored by olasd on Apr 14 2020, 4:27 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Commits
rDSTO4359874ac8d8: Drop BWCompatInMemoryJournalWriter (released with swh.journal 0.0.30)
Summary

This should also fix the build for swh.loader.core

Test Plan

tox tests pass

Diff Detail

Repository
rDSTO Storage manager
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

olasd created this revision.Apr 14 2020, 4:27 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptApr 14 2020, 4:27 PM
ardumont accepted this revision.Apr 14 2020, 4:29 PM
ardumont added a subscriber: ardumont.

Thanks.

(This was what i got locally)

This revision is now accepted and ready to land.Apr 14 2020, 4:29 PM
swh-public-ci added a comment.Apr 14 2020, 4:33 PM

Build is green

Patch application report for D3018 (id=10727)

Rebasing onto 2cc263da97...

Current branch diff-target is up to date.
Changes applied before test
commit 4359874ac8d8918b2b2e5a0b0c22d449c2ea5a9c
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Tue Apr 14 16:26:18 2020 +0200

    Drop BWCompatInMemoryJournalWriter (released with swh.journal 0.0.30)

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/99/ for more details.

Harbormaster completed remote builds in B11846: Diff 10727.Apr 14 2020, 4:33 PM
Closed by commit rDSTO4359874ac8d8: Drop BWCompatInMemoryJournalWriter (released with swh.journal 0.0.30) (authored by olasd). · Explain WhyApr 14 2020, 5:09 PM
This revision was automatically updated to reflect the committed changes.
olasd added a commit: rDSTO4359874ac8d8: Drop BWCompatInMemoryJournalWriter (released with swh.journal 0.0.30).

Revision Contents
Changeset List

PathSize
2 lines
swh/
storage/
tests/
24 lines
13 lines
7 lines

Diff 10728

View Options

requirements-swh-journal.txt

Loading...
View Options

swh/storage/tests/conftest.py

Loading...
View Options

swh/storage/tests/test_api_client.py

Loading...
View Options

swh/storage/tests/test_api_client_dicts.py

Loading...
About · Developer information · Legal