Differential D2945

model: Make message field optional in Release model
ClosedPublic
Actions

Authored by anlambert on Apr 2 2020, 12:46 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDMOD64a7f620d9c6: model: Make message field optional in Release model

Summary

A release may have an empty message, for instance those derived from a Mercurial repository.

12:45 $ psql service=swh-replica
psql (11.7 (Debian 11.7-0+deb10u1))
Connexion SSL (protocole : TLSv1.3, chiffrement : TLS_AES_256_GCM_SHA384, bits : 256, compression : désactivé)
Saisissez « help » pour l'aide.

softwareheritage=> select id from release where comment is NULL limit 10;
                     id                     
--------------------------------------------
 \xc581a993393d1b61fc7f3964014313734cb4fec1
 \xdab5a0841cf00e46861e15198dd0e57f1a5ca5f9
 \xd39288723941ecaf18b5231377c9885a446d6b59
 \xc61eaa2cbd1438ae60551b8ef3aea2c5da939aae
 \x7acc3693e4661e419d140769f18fb4d2084c7db2
 \xbed8489aedbe51e646440cfd5b49f2f43eb20555
 \x68f7ceeaea00deddbf15e17bb1414eb7725c89d7
 \xc471bbed0a05d8f822a820744f05754140c51893
 \x3d74278a26b139adcee267a49d1542c14dfe1f31
 \x39eeabe99031ba4803986e7dfc816ec15b4151c4
(10 lignes)

So make that field optional to avoid type validation errors.

Diff Detail

Repository

rDMOD Data model

Branch

release-optional-message

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 11572
Build 17543: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 17542: arc lint + arc unit

Event Timeline

anlambert created this revision.Apr 2 2020, 12:46 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptApr 2 2020, 12:46 PM

Build is green

Patch application report for D2945 (id=10480)

Rebasing onto 074c2104a5...

Current branch diff-target is up to date.

Changes applied before test

commit 0485579c92d55ccb82a677e262ba8d7e06218c5f
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Thu Apr 2 12:44:45 2020 +0200

    model: Make message field optional in Release model
    
    A release may have an empty message, for instance those derived from a Mercurial
    repository. So make that field optional to avoid type validation errors.

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/29/ for more details.

Harbormaster completed remote builds in B11572: Diff 10480.Apr 2 2020, 12:47 PM

anlambert mentioned this in D2936: loader-mercurial: Port to swh-model objects instead of dicts.Apr 2 2020, 1:57 PM

ardumont accepted this revision.Apr 2 2020, 1:59 PM

This revision is now accepted and ready to land.Apr 2 2020, 1:59 PM

Update commit message

Build is green

Patch application report for D2945 (id=10482)

Rebasing onto 074c2104a5...

Current branch diff-target is up to date.

Changes applied before test

commit 64a7f620d9c69de1e0c6ea7ae26f5f34b8c2e85a
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Thu Apr 2 12:44:45 2020 +0200

    model: Make message field optional in Release model
    
    A release may have an empty message, for instance those derived from
    a Mercurial repository.
    
    So make that field optional to avoid type validation errors.

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/30/ for more details.

Harbormaster completed remote builds in B11574: Diff 10482.Apr 2 2020, 2:02 PM

Closed by commit rDMOD64a7f620d9c6: model: Make message field optional in Release model (authored by anlambert). · Explain WhyApr 2 2020, 2:02 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDMOD64a7f620d9c6: model: Make message field optional in Release model.