Page MenuHomeSoftware Heritage
Differential D2836

Remove extra 'perms' key of contents when replaying.
ClosedPublic
Actions

Authored by vlorentz on Mar 16 2020, 4:29 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Commits
rDJNL4ce176266779: Remove extra 'perms' key of contents when replaying.
Summary

It crashes when the dict is converted to an swh-model object.

Diff Detail

Repository
rDJNL Journal infrastructure
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 11155
Build 16838: tox-on-jenkinsJenkins
Build 16837: arc lint + arc unit

Event Timeline

vlorentz created this revision.Mar 16 2020, 4:29 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptMar 16 2020, 4:29 PM
swh-public-ci added a comment.Mar 16 2020, 4:33 PM

Build is green
See https://jenkins.softwareheritage.org/job/DJNL/job/tox/398/ for more details.

Harbormaster completed remote builds in B11155: Diff 10086.Mar 16 2020, 4:33 PM
ardumont accepted this revision.Mar 16 2020, 6:08 PM
This revision is now accepted and ready to land.Mar 16 2020, 6:08 PM
ardumont requested changes to this revision.Mar 17 2020, 10:12 AM

I accepted, re-read and see we are missing type on the new function.
Please add them first ;)

swh/journal/replay.py
71

type!

This revision now requires changes to proceed.Mar 17 2020, 10:12 AM
vlorentz updated this revision to Diff 10094.Mar 17 2020, 10:18 AM

add annotation

swh-public-ci added a comment.Mar 17 2020, 10:22 AM

Build is green
See https://jenkins.softwareheritage.org/job/DJNL/job/tox/399/ for more details.

Harbormaster completed remote builds in B11163: Diff 10094.Mar 17 2020, 10:22 AM
ardumont accepted this revision.Mar 17 2020, 10:35 AM
This revision is now accepted and ready to land.Mar 17 2020, 10:35 AM
Closed by commit rDJNL4ce176266779: Remove extra 'perms' key of contents when replaying. (authored by vlorentz). · Explain WhyMar 17 2020, 10:38 AM
This revision was automatically updated to reflect the committed changes.
vlorentz added a commit: rDJNL4ce176266779: Remove extra 'perms' key of contents when replaying..

Revision Contents
Changeset List

PathSize
swh/
journal/
18 lines

Diff 10086

View Options

swh/journal/replay.py

Loading...
About · Developer information · Legal