Changeset View
Standalone View
swh/storage/archiver/__init__.py
- This file was added.
from .director import ArchiverDirector # NOQA | |||||
ardumont: why the # noqa? | |||||
Not Done Inline ActionsOk, discussing with Quentin, it's due to the pre-commit-hook we have installed which refuses to let the user commits if there are some pep8 violations. And, as the module is imported but in appearance not used, for flake8, it's a fail. We need to find a way to improve on this (or not). I know it's possible to have some setup file for flake8 to ignore some errors (this one is F401). Also, i found this which relates to this http://stackoverflow.com/questions/31079047/python-pep8-class-in-init-imported-but-not-used. Following the proposed solution, this'd give something like: from .director import ArchiverDirector from .worker import ArchiverWorker from .copier import ArchiverCopier __all__ = ['ArchiverDirector', 'ArchiverWorker', 'ArchiverCopier'] I don't know if this is reasonable or not but it works. ardumont: Ok, discussing with Quentin, it's due to the pre-commit-hook we have installed which refuses to… | |||||
from .worker import ArchiverWorker # NOQA | |||||
from .copier import ArchiverCopier # NOQA |
why the # noqa?