Page MenuHomeSoftware Heritage

Images with src within repo dont render in Readme
Closed, ResolvedPublic

Description

Images which has source within the repo doesnt show up in the readme.

Paths with leading slash display as broken image link.
While those without a leading slash has an empty value in src tag.

First one (with leading slash) points to path relative to root directory. So the link is broken.

Second one(when there's no leading slash) is caused because of the D1322 (showdown-xss-filter).

example-
https://archive.softwareheritage.org/browse/origin/https://github.com/kalpitk/t//visit/2019-04-10T17:13:30.059776+00:00/directory/

Event Timeline

kalpitk created this task.Apr 10 2019, 7:26 PM
kalpitk created this object in space S1 Public.
kalpitk triaged this task as Low priority.
kalpitk renamed this task from Images with src within repo dont render to Images with src within repo dont render in Readme.Apr 10 2019, 7:30 PM
kalpitk updated the task description. (Show Details)Apr 11 2019, 9:35 AM

@kalpitk , I have submitted D1412 fixing the observed issues. What do you think ?

kalpitk added a comment.EditedApr 13 2019, 8:22 AM

@anlambert

I can confirm, all the 4 codes below work with your commit and xss is too not working.

<img src="/1.png"/>

<img src="1.png"/>

![Solid Logo](/1.png)

![Solid Logo](1.png)