Description

Images which has source within the repo doesnt show up in the readme.

Paths with leading slash display as broken image link.
While those without a leading slash has an empty value in src tag.

First one (with leading slash) points to path relative to root directory. So the link is broken.

Second one(when there's no leading slash) is caused because of the D1322 (showdown-xss-filter).

Revisions and Commits

rDWAPPS Web applications
	D1412	rDWAPPS6cbad0ef83c3 assets/readme-rendering: Use dompurify as XSS filter instead of xss

Mentioned In: D1412: assets/readme-rendering: Use dompurify as XSS filter
Mentioned Here: D1412: assets/readme-rendering: Use dompurify as XSS filter
D1322: fix XSS vulnerability in readme rendering for txt, md

kalpitk triaged this task as Low priority.Apr 10 2019, 7:26 PM

kalpitk created this task.

kalpitk created this object in space S1 Public.

kalpitk renamed this task from Images with src within repo dont render to Images with src within repo dont render in Readme.Apr 10 2019, 7:30 PM

@kalpitk , I have submitted D1412 fixing the observed issues. What do you think ?

I can confirm, all the 4 codes below work with your commit and xss is too not working.

<img src="/1.png"/>

<img src="1.png"/>

![Solid Logo](/1.png)

![Solid Logo](1.png)