Page MenuHomeSoftware Heritage

Deposit: Refactor tests using pytest
Closed, ResolvedPublic

Description

Deposit is tested fine.

Most probably, those tests are not that well written though.
I remermber there are some repetitions in the setup bootstrap.
Also, it's the occasion to start converging on the pytest framework (using dedicated fixtures) as the other modules start to do.

Event Timeline

ardumont triaged this task as Normal priority.Mar 12 2019, 12:20 PM
ardumont created this task.
ardumont renamed this task from Refactor deposit tests to Deposit: Refactor tests.Mar 12 2019, 2:45 PM

The deposit cli is not though.

Most probably, those tests are not that well written though.

Well, what i meant was that they could use a simpler bootstrap.
Probably using pytest fixtures would help a lot ;)

ardumont removed ardumont as the assignee of this task.Jul 3 2019, 3:26 PM
ardumont renamed this task from Deposit: Refactor tests to Deposit: Refactor tests using pytest.Oct 21 2019, 9:24 AM
ardumont updated the task description. (Show Details)
ardumont closed this task as Resolved.Oct 21 2019, 3:47 PM
ardumont claimed this task.