HomeSoftware Heritage

Make the storage test fixture connect to postgres itself
e1e502547c11Unpublished

Unpublished Commit · Learn More

Repository Importing: This repository is still importing.

Description

Make the storage test fixture connect to postgres itself

Summary:
This avoids reusing a potentially stale connection handle. Also allows testing
potential connection pooling behavior.

This forces us to do proper cursor sanitation as well, a bunch of
"transactional" operations weren't actually transactional.

Test Plan: another round of make test still working

Reviewers: Reviewers!

Differential Revision: https://forge.softwareheritage.org/D323

Details

Provenance
olasdAuthored on May 4 2018, 4:32 PM
olasdPushed on May 7 2018, 3:46 PM
Differential Revision
D323: Make the storage test fixture connect to postgres itself
Parents
R65:ff2d37d7c64d: Deallocate storage when the tests teardown
Branches
Unknown
Tags
Unknown
References
tag: phabricator/base/1052