HomeSoftware Heritage

fix(install.sh): skip checking for sse4 2 flag if kvm was detected (#485)

Description

fix(install.sh): skip checking for sse4 2 flag if kvm was detected (#485)

This PR disables checking for the SSE4.2 flag, which may not be present if the server is running in a VM even if SSE4.2 is in fact available to use (ClickHouse/ClickHouse#20). The KVM check was obtained from a comment in that issue.

If SSE4.2 is not actually available in the VM, then the installation script may fail in an unpredictable way. Perhaps we can add a keyword argument to the script to let the user decide if they want to skip the check.

Details

Provenance
Mohamed Laradji <mlaradji@protonmail.ch>Authored on May 9 2020, 10:10 PM
GitHub <noreply@github.com>Committed on May 9 2020, 10:10 PM
olasdPushed on Dec 15 2020, 11:43 AM
Parents
R206:ad5b76fd29f5: Updating documentation link (#467)
Branches
Unknown
Tags
Unknown

Event Timeline

GitHub <noreply@github.com> committed R206:45320c6e863d: fix(install.sh): skip checking for sse4 2 flag if kvm was detected (#485) (authored by Mohamed Laradji <mlaradji@protonmail.ch>).May 9 2020, 10:10 PM