HomeSoftware Heritage

ci: Increase pool size to prevent pool closed errors (#819)

Description

ci: Increase pool size to prevent pool closed errors (#819)

Based on my reading, this error comes from urllib3.

https://urllib3.readthedocs.io/en/latest/advanced-usage.html

The behavior of the pooling for ConnectionPool is different from PoolManager. By default, if a new request is made and there is no free connection in the pool then a new connection will be created. However, this connection will not be saved if more than maxsize connections exist. This means that maxsize does not determine the maximum number of connections that can be open to a particular host, just the maximum number of connections to keep in the pool.

I think the ideal solution would be to add retry and block options to docker-py but that's a long shot.

Details

Provenance
Burak Yigit Kaya <byk@sentry.io>Authored on Jan 15 2021, 9:20 PM
GitHub <noreply@github.com>Committed on Jan 15 2021, 9:20 PM
olasdPushed on Sep 2 2021, 4:39 PM
Parents
R206:cc31349cc4ee: build: Set master version to nightly
Branches
Unknown
Tags
Unknown

Event Timeline

GitHub <noreply@github.com> committed R206:2e4307b553da: ci: Increase pool size to prevent pool closed errors (#819) (authored by Burak Yigit Kaya <byk@sentry.io>).Jan 15 2021, 9:20 PM