HomeSoftware Heritage

Make it possible to use pod's network

Description

Make it possible to use pod's network

To use pod's network in a container, it shuld have --pod argument
and should not have --net.
The latter was always being added to the docker run command, if
not provided to the class as a parameter, then defaults to 'bridge'.
If empty or empty arrar - added as '' which also breaks networking
for the container in the pod.

With this fix, if a network is not defined, the whole argument will
be omitted in the docker run / docker create flags. This is the
same as providing previous default 'bridge' if container is created
or started without '--pod', and is not breaking compatibility with
podman create/run command without explicit '--net' argument.

Details

Provenance
Sergey Ivanov <seriv@cs.umd.edu>Authored on Feb 19 2021, 5:30 PM
olasdPushed on Dec 28 2021, 10:47 AM
Parents
R205:ce4a0a4815ff: Merge pull request #723 from puppetlabs/maint/main/version_dependency_bump
Branches
Unknown
Tags
Unknown

Event Timeline

Sergey Ivanov <seriv@cs.umd.edu> committed R205:ad0247f9db4e: Make it possible to use pod's network (authored by Sergey Ivanov <seriv@cs.umd.edu>).Feb 24 2021, 11:24 PM