HomeSoftware Heritage

docker::services: Fix using multiple published ports (#447)
a2046798977cUnpublished

Unpublished Commit · Learn More

  • Repository Importing: This repository is still importing.
  • Not On Permanent Ref: This commit is not an ancestor of any permanent ref.

Description

docker::services: Fix using multiple published ports (#447)

While the class docker::services already allowed arrays to be
specified for publish ports, it didn't handle this correctly since
this array was simply converted to a string and passed onto Docker,
like so:

    --publish '["80:80", "443:443"]'

To correctly publish multiple ports, the --publish parameter has to
be called specified for each port.

    --publish '80:80' --publish '443:443'

This patch also introduces a new spec test to check this behavior

Details

Provenance
Jack <jackdev@mailbox.org>Authored on Mar 4 2019, 11:11 AM
davejrt <2067825+davejrt@users.noreply.github.com>Committed on Mar 4 2019, 11:11 AM
olasdPushed on Dec 2 2019, 6:03 PM
Parents
R205:01932d745a9d: release for v3.4.0 (#442)
Branches
Unknown
Tags
Unknown

Event Timeline