HomeSoftware Heritage

Use `relative_require` in artifactory functions

Description

Use relative_require in artifactory functions

This doesn't seem to have been neccessary for all users and probably
depends on how puppetserver has ruby-load-path configured.
See https://tickets.puppetlabs.com/browse/SERVER-973?focusedCommentId=224547&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-224547

Requiring the library using an absolute path should help
https://tickets.puppetlabs.com/browse/SERVER-973?focusedCommentId=352751&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-352751

Note, any changes to util.rb will still result in horrible environment
isolation issues. A full fix would involve implementing
@trevor-vaughan's complete metaprogramming solution documented here.
https://www.onyxpoint.com/fixing-the-client-side-of-multi-tenancy-in-the-puppet-server

util.rb is somewhat more complicated than the example demonstrated, so
I've left that well alone for now.

Fixes #320

Details

Provenance
Alexander Fisher <alex@linfratech.co.uk>Authored on Dec 6 2019, 2:47 PM
olasdPushed on Dec 24 2019, 2:34 PM
Parents
R144:8457135f9af7: Merge pull request #389 from dhoppe/remove_duplicate
Branches
Unknown
Tags
Unknown

Event Timeline

Alexander Fisher <alex@linfratech.co.uk> committed R144:7437db146237: Use `relative_require` in artifactory functions (authored by Alexander Fisher <alex@linfratech.co.uk>).Dec 6 2019, 2:47 PM