Page MenuHomeSoftware Heritage
Differential D980

Rewrite celery tasks as decorated functions
ClosedPublic
Actions

Authored by douardda on Jan 17 2019, 5:57 PM.

Details

Reviewers
olasd
Group Reviewers
Reviewers
Commits
rDCIDXa42b889ae933: Rewrite celery tasks as decorated functions
rDCIDXcfd030e68526: Rename s/i/tests/test_utils.py as s/i/t/utils.py
Summary

Also rename s/i/tests/test_utils.py as s/i/t/utils.py
so pytest does not try to execute this file.

related to T1480

Test Plan

there is one test that fails on my machine (with tox),

Metadata.test_compute_metadata_pkginfo (test_metadata.py:670)

Diff Detail

Repository
rDCIDX Metadata indexer
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.Jan 17 2019, 5:57 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptJan 17 2019, 5:57 PM
douardda mentioned this in T1480: Refactor tasks code as decorated functions using swh-scheduler 0.0.39.Jan 17 2019, 5:57 PM
swh-public-ci added a subscriber: swh-public-ci.Jan 17 2019, 6:00 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/234/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/234/console

Harbormaster failed remote builds in B3610: Diff 3097!Jan 17 2019, 6:00 PM
douardda updated this revision to Diff 3099.Jan 18 2019, 9:47 AM

Fix ws mangling in test_metadata.py

swh-public-ci added a comment.Jan 18 2019, 9:50 AM

Build is green
See https://jenkins.softwareheritage.org/job/DCIDX/job/tox/235/ for more details.

Harbormaster completed remote builds in B3612: Diff 3099.Jan 18 2019, 9:50 AM
olasd accepted this revision.Jan 18 2019, 2:25 PM
This revision is now accepted and ready to land.Jan 18 2019, 2:25 PM
Closed by commit rDCIDXcfd030e68526: Rename s/i/tests/test_utils.py as s/i/t/utils.py (authored by douardda). · Explain WhyJan 18 2019, 2:29 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 3101

View Options

swh/indexer/tests/tasks.py

Loading...
View Options

swh/indexer/tests/test_ctags.py

Loading...
View Options

swh/indexer/tests/test_fossology_license.py

Loading...
View Options

swh/indexer/tests/test_language.py

Loading...
View Options

swh/indexer/tests/test_metadata.py

Loading...
View Options

swh/indexer/tests/test_mimetype.py

Loading...
View Options

swh/indexer/tests/test_origin_head.py

Loading...
View Options

swh/indexer/tests/test_origin_metadata.py

Loading...
View Options

swh/indexer/tests/test_utils.py

Loading...
View Options

swh/indexer/tests/utils.py

Loading...
About · Developer information · Legal