Page MenuHomeSoftware Heritage
Differential D90

browse: remove argumentless routes
ClosedPublic
Actions

Authored by jbertran on Aug 1 2016, 4:04 PM.

Details

Reviewers
zack
Group Reviewers
Reviewers
Maniphest Tasks
T521: Consistent error behaviour on incomplete browse urls
Commits
R65:a4607b8fe77c: browse: remove argumentless routes
rDWAPPSa4607b8fe77c: browse: remove argumentless routes
Summary

Fixes T521

Diff Detail

Repository
rDWAPPS Web applications
Branch
T521
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 331
Build 495: Software Heritage Python tests
Build 494: arc lint + arc unit

Event Timeline

jbertran updated this revision to Diff 293.Aug 1 2016, 4:04 PM
jbertran added a task: T521: Consistent error behaviour on incomplete browse urls.
jbertran retitled this revision from to browse: remove argumentless routes.
jbertran updated this object.
jbertran edited the test plan for this revision. (Show Details)
Herald added a reviewer: Reviewers. · View Herald TranscriptAug 1 2016, 4:04 PM
jbertran added a comment.EditedAug 1 2016, 4:05 PM

Gah, ignore this for the moment.

jbertran updated this revision to Diff 294.Aug 1 2016, 4:09 PM
jbertran edited edge metadata.
  • Search template: fix wonky url_for call
Herald edited edge metadata. · View Herald TranscriptAug 1 2016, 4:09 PM
jbertran updated this revision to Diff 295.Aug 1 2016, 4:11 PM
jbertran edited edge metadata.

Squash ugly fixes together

Herald edited edge metadata. · View Herald TranscriptAug 1 2016, 4:11 PM
zack added a subscriber: zack.Aug 1 2016, 4:11 PM
zack added inline comments.
swh/web/ui/views/browse.py
24

So where is this used? it is not in this diff, nor it seems to be a special name used by Flask.
What am I missing?

jbertran updated this revision to Diff 296.Aug 1 2016, 4:14 PM
jbertran edited edge metadata.

Remove decorator and squash again

Herald edited edge metadata. · View Herald TranscriptAug 1 2016, 4:14 PM
zack accepted this revision.Aug 1 2016, 4:16 PM
zack added a reviewer: zack.
zack added inline comments.
swh/web/ui/views/browse.py
24

(no longer applies with this update)

This revision is now accepted and ready to land.Aug 1 2016, 4:16 PM
Closed by commit rDWAPPSa4607b8fe77c: browse: remove argumentless routes (authored by jbertran). · Explain WhyAug 1 2016, 4:17 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
swh/
web/
ui/
templates/
2 lines
views/
35 lines

Diff 295

View Options

swh/web/ui/templates/search.html

Loading...
View Options

swh/web/ui/views/browse.py

Loading...
About · Developer information · Legal