Differential D8928

grab_next_visits: Open lister name and instance name filtering
ClosedPublic
Actions

Authored by ardumont on Dec 6 2022, 5:04 PM.

Details

Reviewers

None

Group Reviewers

Reviewers

Commits

rDSCHcd16fce903ad: grab_next_visits: Open lister name and instance name filtering

Summary

Depends on D8922

Test Plan

One new test added

Diff Detail

Repository

rDSCH Scheduling utilities

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Dec 6 2022, 5:04 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptDec 6 2022, 5:04 PM

ardumont mentioned this in D8922: send-to-celery: Adapt to schedule from lister name & instance_name.Dec 6 2022, 5:04 PM

Build is green

Patch application report for D8928 (id=32150)

Could not rebase; Attempt merge onto ff75e742ee...

Updating ff75e74..cd16fce
Fast-forward
 swh/scheduler/backend.py               | 23 +++++++++++++++++++++--
 swh/scheduler/cli/origin.py            | 19 ++++++++++++++++---
 swh/scheduler/interface.py             |  5 +++++
 swh/scheduler/tests/common.py          |  2 +-
 swh/scheduler/tests/test_cli_origin.py |  9 ++++++++-
 swh/scheduler/tests/test_scheduler.py  | 33 ++++++++++++++++++++++++++++-----
 swh/scheduler/tests/test_utils.py      |  4 ++--
 7 files changed, 81 insertions(+), 14 deletions(-)

Changes applied before test

commit cd16fce903adde6bd6c9208871260c47c54d5423
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Dec 6 17:01:41 2022 +0100

    grab_next_visits: Open lister name and instance name filtering
    
    Related to https://gitlab.softwareheritage.org/infra/sysadm-environment/-/issues/4674

commit a7769639df76bd2de93911cf10fb9e50d7d15b64
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Dec 6 12:24:33 2022 +0100

    send-to-celery: Adapt to schedule from lister name & instance_name
    
    This allows to bypass the lister id retrieval step using directly the name and instance
    name of the lister to discover the uuid.
    
    This also drops the --lister-uuid flag which is somewhat difficult to use.
    
    Related to https://gitlab.softwareheritage.org/infra/sysadm-environment/-/issues/4674

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/575/ for more details.

Harbormaster completed remote builds in B33103: Diff 32150.Dec 6 2022, 5:08 PM

ardumont requested review of this revision.Dec 6 2022, 5:08 PM

This revision was not accepted when it landed; it landed in state Needs Review.Dec 6 2022, 6:12 PM

Closed by commit rDSCHcd16fce903ad: grab_next_visits: Open lister name and instance name filtering (authored by ardumont). · Explain Why

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDSCHcd16fce903ad: grab_next_visits: Open lister name and instance name filtering.

num num num... i did not mean to push that one.
Please, tell me if i need to revert it...