Differential D8826

browse/origin-search: Percent encode ? character only in origin URL
ClosedPublic
Actions

Authored by anlambert on Nov 9 2022, 5:05 PM.

Details

Reviewers

None

Group Reviewers

Reviewers

Maniphest Tasks

T4675: /browse/search/ crashes when swh-search results are not in swh-storage

Commits

rDWAPPS4bd225b8225c: browse/origin-search: Percent encode ? character only in origin URL

Summary

When an origin URL is provided as URL argument to a Web API call performed
by XHR, only percent encode the '?' character as using encodeURIComponent
results in a 404 error in production and staging otherwise (maybe a side
effect of Varnish cache).

Related to T4675

Diff Detail

Repository

rDWAPPS Web applications

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 32758
Build 51324: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 51323: arc lint + arc unit

Event Timeline

anlambert created this revision.Nov 9 2022, 5:05 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptNov 9 2022, 5:05 PM

Build has FAILED

Patch application report for D8826 (id=31819)

Rebasing onto 64b3d74a82...

Current branch diff-target is up to date.

Changes applied before test

commit 4bd225b8225c7f788e1767f5e1bc3e7cd26cb811
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Wed Nov 9 17:02:49 2022 +0100

    browse/origin-search: Percent encode ? character only in origin URL
    
    When an origin URL is provided as URL argument to a Web API call performed
    by XHR, only percent encode the '?' character as using encodeURIComponent
    results in a 404 error in production and staging otherwise (maybe a side
    effect of Varnish cache).
    
    Related to T4675

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/2127/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/2127/console

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 9 2022, 5:15 PM

Harbormaster failed remote builds in B32758: Diff 31819!

Build is green

Patch application report for D8826 (id=31819)

Rebasing onto 64b3d74a82...

Current branch diff-target is up to date.

Changes applied before test

commit 4bd225b8225c7f788e1767f5e1bc3e7cd26cb811
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Wed Nov 9 17:02:49 2022 +0100

    browse/origin-search: Percent encode ? character only in origin URL
    
    When an origin URL is provided as URL argument to a Web API call performed
    by XHR, only percent encode the '?' character as using encodeURIComponent
    results in a 404 error in production and staging otherwise (maybe a side
    effect of Varnish cache).
    
    Related to T4675

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/2128/ for more details.

Harbormaster completed remote builds in B32758: Diff 31819.Nov 9 2022, 5:25 PM

This revision was not accepted when it landed; it landed in state Needs Review.Nov 9 2022, 5:25 PM

anlambert requested review of this revision.

Closed by commit rDWAPPS4bd225b8225c: browse/origin-search: Percent encode ? character only in origin URL (authored by anlambert). · Explain Why

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPS4bd225b8225c: browse/origin-search: Percent encode ? character only in origin URL.