tests: Simplify cvs loading task creation test implementation
ClosedPublic
Actions

Authored by anlambert on Oct 18 2022, 1:34 PM.

Details

Reviewers

None

Group Reviewers

Reviewers

Commits

rDLDCVSde594fcab27e: tests: Simplify cvs loading task creation test implementation

Summary

Use helper fixture loading_task_creation_for_listed_origin_test from
swh-loader-core and remove redundant test.

Diff Detail

Repository

rDLDCVS CVS Loader

Branch

test-tasks-simplify

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 32361
Build 50688: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 50687: arc lint + arc unit

Event Timeline

anlambert created this revision.Oct 18 2022, 1:34 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptOct 18 2022, 1:34 PM

Build is green

Patch application report for D8700 (id=31413)

Rebasing onto 3bf543ba31...

Current branch diff-target is up to date.

Changes applied before test

commit 9b47d8aefa55b9c011c353b77f4acc3214cb4bc2
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Oct 18 13:34:18 2022 +0200

    tests: Simplify cvs loading task creation test implementation
    
    Use helper fixture loading_task_creation_for_listed_origin_test from
    swh-loader-core and remove redundant test.

See https://jenkins.softwareheritage.org/job/DLDCVS/job/tests-on-diff/138/ for more details.

Harbormaster completed remote builds in B32358: Diff 31413.Oct 18 2022, 1:37 PM

anlambert requested review of this revision.Oct 18 2022, 1:37 PM

Parametrize test with extra loader arguments

Build is green

Patch application report for D8700 (id=31416)

Rebasing onto 3bf543ba31...

Current branch diff-target is up to date.

Changes applied before test

commit de594fcab27e9757d74775c8c4211cfac377e01a
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Oct 18 13:34:18 2022 +0200

    tests: Simplify cvs loading task creation test implementation
    
    Use helper fixture loading_task_creation_for_listed_origin_test from
    swh-loader-core and remove redundant test.

See https://jenkins.softwareheritage.org/job/DLDCVS/job/tests-on-diff/139/ for more details.

Harbormaster completed remote builds in B32361: Diff 31416.Oct 18 2022, 1:57 PM

This revision was not accepted when it landed; it landed in state Needs Review.Oct 18 2022, 3:45 PM

Closed by commit rDLDCVSde594fcab27e: tests: Simplify cvs loading task creation test implementation (authored by anlambert). · Explain Why

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDLDCVSde594fcab27e: tests: Simplify cvs loading task creation test implementation.