Differential D870

deposit.loader.tasks: Add tests
ClosedPublic
Actions

Authored by ardumont on Dec 20 2018, 5:42 PM.

Details

Reviewers

olasd

Group Reviewers

Reviewers

Commits

rDDEPde5cf1a26aab: loader.scheduler: Remove non production code
rDDEPcdf911dbcd47: deposit.loader.tasks: Add tests

Summary

Adding coverage on tasks so that the soon to be refactoring on that
part feels less flaky.

Also non production code.

Test Plan

tox

Diff Detail

Repository

rDDEP Push deposit

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Dec 20 2018, 5:42 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptDec 20 2018, 5:42 PM

Build is green
See https://jenkins.softwareheritage.org/job/DDEP/job/tox/77/ for more details.

Harbormaster completed remote builds in B3222: Diff 2771.Dec 20 2018, 5:45 PM

olasd accepted this revision.Dec 20 2018, 6:04 PM

This revision is now accepted and ready to land.Dec 20 2018, 6:04 PM

Closed by commit rDDEPcdf911dbcd47: deposit.loader.tasks: Add tests (authored by ardumont). · Explain WhyDec 20 2018, 6:28 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

swh/

deposit/

loader/

tasks.py

7 lines

tests/

loader/

test_tasks.py

50 lines

Diff 2773

View Options

swh/deposit/loader/tasks.py