fix deposit loader tests and unbreak the CI
ClosedPublic
Actions

Authored by ardumont on Dec 20 2018, 4:01 PM.

Details

Reviewers

Group Reviewers

Commits

rDDEP8c647a81149c: deposit.loader: Fix clash in variable names
rDDEP4e60ea238497: requirements: Bump to latest swh-loader-tar
rDDEP446cad5c8d92: deposit.tests: Add missing default configuration

Summary

deposit.tests: Add missing default configuration
fix clash in variable name between the loader tar and the loader-deposit.

Note:
without tox working locally (P341)
so trying to fix with the ci

Test Plan

tox

Diff Detail

Repository

rDDEP Push deposit

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Dec 20 2018, 4:01 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptDec 20 2018, 4:01 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DDEP/job/tox/75/
See console output for more information: https://jenkins.softwareheritage.org/job/DDEP/job/tox/75/console

Harbormaster failed remote builds in B3214: Diff 2766!Dec 20 2018, 4:04 PM

deposit.loader: Fix clash in variable names
requirements: Bump to latest swh-loader-tar

ardumont retitled this revision from wip: Try to fix ci to wip: fix deposit loader tests.Dec 20 2018, 4:11 PM

ardumont edited the summary of this revision. (Show Details)

Build is green
See https://jenkins.softwareheritage.org/job/DDEP/job/tox/76/ for more details.

Harbormaster completed remote builds in B3215: Diff 2767.Dec 20 2018, 4:13 PM

ardumont retitled this revision from wip: fix deposit loader tests to fix deposit loader tests and unbreak the CI.Dec 20 2018, 4:15 PM

vlorentz accepted this revision.Dec 20 2018, 4:17 PM

This revision is now accepted and ready to land.Dec 20 2018, 4:17 PM

Closed by commit rDDEP446cad5c8d92: deposit.tests: Add missing default configuration (authored by ardumont). · Explain WhyDec 20 2018, 4:18 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

swh/

deposit/

tests/

__init__.py

2 lines

Diff 2769

View Options

fix deposit loader tests and unbreak the CIClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 2769

swh/deposit/tests/__init__.py

fix deposit loader tests and unbreak the CI
ClosedPublic
Actions

Revision Contents
Changeset List

swh/deposit/tests/init.py