Page MenuHomeSoftware Heritage

fix deposit loader tests and unbreak the CI
ClosedPublic

Authored by ardumont on Dec 20 2018, 4:01 PM.

Details

Summary
  • deposit.tests: Add missing default configuration
  • fix clash in variable name between the loader tar and the loader-deposit.

Note:
without tox working locally (P341)
so trying to fix with the ci

Test Plan

tox

Diff Detail

Repository
rDDEP swh-deposit
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Dec 20 2018, 4:01 PM
ardumont updated this revision to Diff 2767.Dec 20 2018, 4:10 PM
  • deposit.loader: Fix clash in variable names
  • requirements: Bump to latest swh-loader-tar
ardumont retitled this revision from wip: Try to fix ci to wip: fix deposit loader tests.Dec 20 2018, 4:11 PM
ardumont edited the summary of this revision. (Show Details)
ardumont retitled this revision from wip: fix deposit loader tests to fix deposit loader tests and unbreak the CI.Dec 20 2018, 4:15 PM
vlorentz accepted this revision.Dec 20 2018, 4:17 PM
This revision is now accepted and ready to land.Dec 20 2018, 4:17 PM
This revision was automatically updated to reflect the committed changes.