Differential D8533

Fix pagination bug in visit statuses
ClosedPublic
Actions

Authored by jayeshv on Sep 26 2022, 12:15 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDGQL8d764671e9ed: Fix pagination bug in visit statuses

Summary

Visit status is using a different cursor in the storage. Override
_get_index_cursor to support that.

Diff Detail

Repository

rDGQL GraphQL API

Branch

visit-status-bug

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 31728
Build 49646: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 49645: arc lint + arc unit

Event Timeline

jayeshv created this revision.Sep 26 2022, 12:15 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptSep 26 2022, 12:15 PM

Build is green

Patch application report for D8533 (id=30751)

Rebasing onto 32d5564f97...

Current branch diff-target is up to date.

Changes applied before test

commit 808909810cba400b1895afbac985f70a66050b9d
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Mon Sep 26 12:12:56 2022 +0200

    Fix pagination bug in visit statuses
    
    Visit status is using a different cursor in the storage. Override
    _get_index_cursor to support that.

See https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/202/ for more details.

Harbormaster completed remote builds in B31728: Diff 30751.Sep 26 2022, 12:17 PM

jayeshv requested review of this revision.Sep 26 2022, 12:17 PM

vlorentz accepted this revision.Sep 26 2022, 2:03 PM

vlorentz added a subscriber: vlorentz.

vlorentz added inline comments.

swh/graphql/tests/functional/test_visit_status.py
95	remove this assertion, it's redundant with the next one, and pytest provides less useful errors on this one.

This revision is now accepted and ready to land.Sep 26 2022, 2:03 PM

address review comment

jayeshv marked an inline comment as done.Sep 26 2022, 2:30 PM

Build is green

Patch application report for D8533 (id=30772)

Rebasing onto 32d5564f97...

Current branch diff-target is up to date.

Changes applied before test

commit 8d764671e9ed86bdf5e20c5cea91866fb54ec907
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Mon Sep 26 12:12:56 2022 +0200

    Fix pagination bug in visit statuses
    
    Visit status is using a different cursor in the storage. Override
    _get_index_cursor to support that.

See https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/203/ for more details.

Harbormaster completed remote builds in B31749: Diff 30772.Sep 26 2022, 2:39 PM

Closed by commit rDGQL8d764671e9ed: Fix pagination bug in visit statuses (authored by jayeshv). · Explain WhySep 26 2022, 2:40 PM

This revision was automatically updated to reflect the committed changes.

jayeshv added a commit: rDGQL8d764671e9ed: Fix pagination bug in visit statuses.