Differential D8323

Remove hard-coded object ids from functional tests
ClosedPublic
Actions

Authored by jayeshv on Aug 26 2022, 3:30 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDGQL4478a533a9b1: Remove hard-coded object ids from functional tests

Summary

Use fixtures instead of hard-coded ids

Diff Detail

Repository

rDGQL GraphQL API

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jayeshv created this revision.Aug 26 2022, 3:30 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptAug 26 2022, 3:30 PM

Build is green

Patch application report for D8323 (id=30064)

Rebasing onto a31419d74c...

Current branch diff-target is up to date.

Changes applied before test

commit d67417db1804595c185415af41c85edcad117560
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Fri Aug 26 15:28:22 2022 +0200

    Remove hard-coded object ids from functional tests
    
    Use fixtures instead of hard-coded ids

See https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/134/ for more details.

Harbormaster completed remote builds in B31111: Diff 30064.Aug 26 2022, 3:32 PM

jayeshv requested review of this revision.Aug 26 2022, 3:32 PM

vlorentz accepted this revision.Aug 26 2022, 3:35 PM

This revision is now accepted and ready to land.Aug 26 2022, 3:35 PM

rebase

Build is green

Patch application report for D8323 (id=30065)

Rebasing onto 97aa757412...

Current branch diff-target is up to date.

Changes applied before test

commit 4478a533a9b138bc5a4cba39662853a3655841b5
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Fri Aug 26 15:28:22 2022 +0200

    Remove hard-coded object ids from functional tests
    
    Use fixtures instead of hard-coded ids

See https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/135/ for more details.

Harbormaster completed remote builds in B31113: Diff 30065.Aug 26 2022, 3:39 PM

Closed by commit rDGQL4478a533a9b1: Remove hard-coded object ids from functional tests (authored by jayeshv). · Explain WhyAug 26 2022, 3:39 PM

This revision was automatically updated to reflect the committed changes.

jayeshv added a commit: rDGQL4478a533a9b1: Remove hard-coded object ids from functional tests.