Differential D82

search: refactor and use sha1_git, sha256
ClosedPublic
Actions

Authored by jbertran on Jul 27 2016, 2:30 PM.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Maniphest Tasks

T380: use all checksums (instead of only sha1) to check for missing files

Commits

R65:41306c71d658: javascript: remove redundant files, fix tab issues
R65:dd92452711e0: search.html: cleanup and reflect javascript changes
R65:6098ee1f831f: search: refactor filedrop.js, new functionalities
rDWAPPS41306c71d658: javascript: remove redundant files, fix tab issues
rDWAPPSdd92452711e0: search.html: cleanup and reflect javascript changes
rDWAPPS6098ee1f831f: search: refactor filedrop.js, new functionalities

Summary

Refactor javascript to minimize html-side scripting
Add sha1_git and sha256 hashing
Completely separate text and file input html
Update and cleanup html template
Remove redundant files

javascript: remove redundant files

Diff Detail

Repository

rDWAPPS Web applications

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jbertran updated this revision to Diff 268.Jul 27 2016, 2:30 PM

jbertran added a task: T380: use all checksums (instead of only sha1) to check for missing files.

jbertran retitled this revision from to search: refactor and use sha1_git, sha256.

jbertran updated this object.

jbertran edited the test plan for this revision. (Show Details)

Herald added a reviewer: Reviewers. · View Herald TranscriptJul 27 2016, 2:30 PM

Fix inconsistent tabs

Herald edited edge metadata. · View Herald TranscriptJul 27 2016, 2:38 PM

Fix issues and squash commit

Herald edited edge metadata. · View Herald TranscriptJul 27 2016, 2:51 PM

zack accepted this revision.Jul 27 2016, 4:16 PM

zack added a reviewer: zack.

This revision is now accepted and ready to land.Jul 27 2016, 4:16 PM

rebase on master

This revision now requires review to proceed.Jul 27 2016, 4:20 PM

zack accepted this revision.Jul 27 2016, 4:20 PM

zack edited edge metadata.

This revision is now accepted and ready to land.Jul 27 2016, 4:20 PM

Closed by commit rDWAPPS6098ee1f831f: search: refactor filedrop.js, new functionalities (authored by jbertran). · Explain WhyJul 27 2016, 4:21 PM

This revision was automatically updated to reflect the committed changes.

jbertran mentioned this in T380: use all checksums (instead of only sha1) to check for missing files.Jul 27 2016, 4:24 PM

Revision Contents
Changeset List

Path

Size

swh/

web/

ui/

static/

js/

242 lines

Diff 274

swh/web/ui/static/js/search.js

Loading...