Differential D8294

browse: Move related templates into dedicated django application
ClosedPublic
Actions

Authored by anlambert on Aug 23 2022, 3:59 PM.

Details

Reviewers

jayeshv

Group Reviewers

Reviewers

Maniphest Tasks

T4398: Create one django application for each webapp feature

Commits

rDWAPPS4b1ee0509861: browse: Move related templates into dedicated django application

Summary

Related to T4398

Diff Detail

Repository

rDWAPPS Web applications

Branch

django-apps-refactoring-browse

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 31004
Build 48498: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 48497: arc lint + arc unit

Event Timeline

anlambert created this revision.Aug 23 2022, 3:59 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptAug 23 2022, 3:59 PM

anlambert added a child revision: D8295: misc: Move SWHID iframe view in browse django application.Aug 23 2022, 4:00 PM

Build is green

Patch application report for D8294 (id=29952)

Rebasing onto eb2cda51ca...

Current branch diff-target is up to date.

Changes applied before test

commit 4b1ee050986129a7b3ee7d0732fa91afe107401d
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Thu Aug 11 17:06:15 2022 +0200

    browse: Move related templates into dedicated django application
    
    Related to T4398

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1996/ for more details.

Harbormaster completed remote builds in B31004: Diff 29952.Aug 23 2022, 4:16 PM

anlambert requested review of this revision.Aug 23 2022, 4:16 PM

jayeshv accepted this revision.Aug 23 2022, 4:41 PM

This revision is now accepted and ready to land.Aug 23 2022, 4:41 PM

Closed by commit rDWAPPS4b1ee0509861: browse: Move related templates into dedicated django application (authored by anlambert). · Explain WhyAug 23 2022, 4:51 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPS4b1ee0509861: browse: Move related templates into dedicated django application.

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

swh/

web/

browse/

snapshot_context.py

8 lines

91%

urls.py

6 lines

86%

views/

content.py

2 lines

69%

directory.py

2 lines

81%

origin.py

2 lines

88%

release.py

2 lines

76%

revision.py

4 lines

63%

	browse/	templates/
	templates/	browse/

	browse-branches.html
	branches.html

4 lines

	browse-content.html
	content.html

6 lines

	browse-directory.html
	directory.html

8 lines

	browse-help.html
	help.html

189 lines

	browse-origin-visits.html
	origin-visits.html

92 lines

	browse-release.html
	release.html

4 lines

	browse-releases.html
	releases.html

4 lines

	browse-revision-log.html
	revision-log.html

6 lines

	browse-revision.html
	revision.html

10 lines

	browse-search.html
	search.html

6 lines

	browse-vault-ui.html
	vault-ui.html

6 lines

browse.html

15 lines

	browse/	templates/	includes/
		templates/	includes/

branch-search.html

16 lines

breadcrumbs.html

23 lines

content-display.html

4 lines

directory-display.html

6 lines

empty-snapshot.html

17 lines

origin-search-form.html

68 lines

38 lines

41 lines

58 lines

123 lines

snapshot-context.html

87 lines

take-new-snapshot.html

74 lines

top-navigation.html

12 lines

vault-common.html

32 lines

vault-create-tasks.html

2 lines

templates/

browse/

includes/

directory-display.html

empty-snapshot.html

origin-search-form.html

snapshot-context.html

take-new-snapshot.html

top-navigation.html

vault-common.html

vault-create-tasks.html

tests/

browse/

views/

test_content.py

34 lines

98%

test_directory.py

16 lines

99%

test_identifiers.py

6 lines

100%

test_origin.py

24 lines

96%

test_release.py

4 lines

100%

test_revision.py

14 lines

98%

test_snapshot.py

18 lines

94%

Diff 29952

View Options

swh/web/browse/snapshot_context.py

View Options

swh/web/browse/templates/browse-branches.html

View Options

swh/web/browse/templates/browse-content.html

View Options

swh/web/browse/templates/browse-directory.html

View Options

swh/web/browse/templates/browse-help.html

View Options

swh/web/browse/templates/browse-origin-visits.html

View Options

swh/web/browse/templates/browse-release.html

View Options

swh/web/browse/templates/browse-releases.html

View Options

swh/web/browse/templates/browse-revision-log.html

View Options

swh/web/browse/templates/browse-revision.html

View Options

swh/web/browse/templates/browse-search.html

View Options

swh/web/browse/templates/browse-vault-ui.html

View Options

swh/web/browse/templates/browse.html

View Options

swh/web/browse/templates/includes/branch-search.html

View Options

swh/web/browse/templates/includes/breadcrumbs.html

View Options

swh/web/browse/templates/includes/content-display.html

View Options

swh/web/browse/templates/includes/directory-display.html

View Options

swh/web/browse/templates/includes/empty-snapshot.html

View Options

swh/web/browse/templates/includes/origin-search-form.html

View Options

swh/web/browse/templates/includes/readme-display.html

View Options

swh/web/browse/templates/includes/revision-info.html

View Options

swh/web/browse/templates/includes/show-metadata.html

View Options

swh/web/browse/templates/includes/show-swhids.html

View Options

swh/web/browse/templates/includes/snapshot-context.html

View Options

swh/web/browse/templates/includes/take-new-snapshot.html

View Options

swh/web/browse/templates/includes/top-navigation.html

View Options

swh/web/browse/templates/includes/vault-common.html

View Options

swh/web/browse/templates/includes/vault-create-tasks.html

View Options

swh/web/browse/urls.py

View Options

swh/web/browse/views/content.py

View Options

swh/web/browse/views/directory.py

View Options

swh/web/browse/views/origin.py

View Options

swh/web/browse/views/release.py

View Options

swh/web/browse/views/revision.py

View Options

swh/web/templates/browse/branches.html

View Options

swh/web/templates/browse/browse.html

View Options

swh/web/templates/browse/content.html

View Options

swh/web/templates/browse/directory.html

View Options

swh/web/templates/browse/help.html

View Options

swh/web/templates/browse/layout.html

View Options

swh/web/templates/browse/origin-visits.html

View Options

swh/web/templates/browse/release.html

View Options

swh/web/templates/browse/releases.html

View Options

swh/web/templates/browse/revision-log.html

View Options

swh/web/templates/browse/revision.html

View Options

swh/web/templates/browse/search.html

View Options

swh/web/templates/browse/vault-ui.html

View Options

swh/web/templates/includes/branch-search.html

View Options

swh/web/templates/includes/breadcrumbs.html

View Options

swh/web/templates/includes/content-display.html

View Options

swh/web/templates/includes/directory-display.html

View Options

swh/web/templates/includes/empty-snapshot.html

View Options

swh/web/templates/includes/origin-search-form.html

View Options

swh/web/templates/includes/readme-display.html

View Options

swh/web/templates/includes/revision-info.html

View Options

swh/web/templates/includes/show-metadata.html

View Options

swh/web/templates/includes/show-swhids.html

View Options

swh/web/templates/includes/snapshot-context.html

View Options

swh/web/templates/includes/take-new-snapshot.html

View Options

swh/web/templates/includes/top-navigation.html

View Options

swh/web/templates/includes/vault-common.html

View Options

swh/web/templates/includes/vault-create-tasks.html

View Options

swh/web/tests/browse/views/test_content.py

View Options

swh/web/tests/browse/views/test_directory.py

View Options

swh/web/tests/browse/views/test_identifiers.py

View Options

swh/web/tests/browse/views/test_origin.py

View Options

swh/web/tests/browse/views/test_release.py

View Options

swh/web/tests/browse/views/test_revision.py

View Options

swh/web/tests/browse/views/test_snapshot.py

browse: Move related templates into dedicated django applicationClosedPublicActions

Details

Diff Detail

Event Timeline

Patch application report for D8294 (id=29952)

Changes applied before test

Revision ContentsChangeset List

Diff 29952

swh/web/browse/snapshot_context.py

swh/web/browse/templates/browse-branches.html

swh/web/browse/templates/browse-content.html

swh/web/browse/templates/browse-directory.html

swh/web/browse/templates/browse-help.html

swh/web/browse/templates/browse-origin-visits.html

swh/web/browse/templates/browse-release.html

swh/web/browse/templates/browse-releases.html

swh/web/browse/templates/browse-revision-log.html

swh/web/browse/templates/browse-revision.html

swh/web/browse/templates/browse-search.html

swh/web/browse/templates/browse-vault-ui.html

swh/web/browse/templates/browse.html

swh/web/browse/templates/includes/branch-search.html

swh/web/browse/templates/includes/breadcrumbs.html

swh/web/browse/templates/includes/content-display.html

swh/web/browse/templates/includes/directory-display.html

swh/web/browse/templates/includes/empty-snapshot.html

swh/web/browse/templates/includes/origin-search-form.html

swh/web/browse/templates/includes/readme-display.html

swh/web/browse/templates/includes/revision-info.html

swh/web/browse/templates/includes/show-metadata.html

swh/web/browse/templates/includes/show-swhids.html

swh/web/browse/templates/includes/snapshot-context.html

swh/web/browse/templates/includes/take-new-snapshot.html

swh/web/browse/templates/includes/top-navigation.html

swh/web/browse/templates/includes/vault-common.html

swh/web/browse/templates/includes/vault-create-tasks.html

swh/web/browse/urls.py

swh/web/browse/views/content.py

swh/web/browse/views/directory.py

swh/web/browse/views/origin.py

swh/web/browse/views/release.py

swh/web/browse/views/revision.py

swh/web/templates/browse/branches.html

swh/web/templates/browse/browse.html

swh/web/templates/browse/content.html

swh/web/templates/browse/directory.html

swh/web/templates/browse/help.html

swh/web/templates/browse/layout.html

swh/web/templates/browse/origin-visits.html

swh/web/templates/browse/release.html

swh/web/templates/browse/releases.html

swh/web/templates/browse/revision-log.html

swh/web/templates/browse/revision.html

swh/web/templates/browse/search.html

swh/web/templates/browse/vault-ui.html

swh/web/templates/includes/branch-search.html

swh/web/templates/includes/breadcrumbs.html

swh/web/templates/includes/content-display.html

swh/web/templates/includes/directory-display.html

swh/web/templates/includes/empty-snapshot.html

swh/web/templates/includes/origin-search-form.html

swh/web/templates/includes/readme-display.html

swh/web/templates/includes/revision-info.html

swh/web/templates/includes/show-metadata.html

swh/web/templates/includes/show-swhids.html

swh/web/templates/includes/snapshot-context.html

swh/web/templates/includes/take-new-snapshot.html

swh/web/templates/includes/top-navigation.html

swh/web/templates/includes/vault-common.html

swh/web/templates/includes/vault-create-tasks.html

swh/web/tests/browse/views/test_content.py

swh/web/tests/browse/views/test_directory.py

swh/web/tests/browse/views/test_identifiers.py

swh/web/tests/browse/views/test_origin.py

swh/web/tests/browse/views/test_release.py

swh/web/tests/browse/views/test_revision.py

swh/web/tests/browse/views/test_snapshot.py

browse: Move related templates into dedicated django application
ClosedPublic
Actions

Revision Contents
Changeset List