Page MenuHomeSoftware Heritage
Differential D8200

update text for add forge now email to forge admin
ClosedPublic
Actions

Authored by bchauvet on Aug 5 2022, 1:58 PM.

Details

Reviewers
anlambert
Group Reviewers
Reviewers
Maniphest Tasks
T4424: Update for add forge now email template to forge admin
Commits
rDWAPPS16ba15e51ece: update text for add forge now email to forge admin
Summary

related to T4424

Diff Detail

Repository
rDWAPPS Web applications
Branch
add-forge-now-email
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 30655
Build 47931: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 47930: arc lint + arc unit

Event Timeline

bchauvet created this revision.Aug 5 2022, 1:58 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptAug 5 2022, 1:58 PM
swh-public-ci added a comment.Aug 5 2022, 2:08 PM

Build has FAILED

Patch application report for D8200 (id=29591)

Rebasing onto 708fb87322...

First, rewinding head to replay your work on top of it...
Applying: update text for add forge now email to forge admin
Changes applied before test
commit 9527cc3bf69394cd3dc2a7bf78485955c33095bb
Author: Benoit Chauvet <contact@benoitchauvet.com>
Date:   Fri Aug 5 12:07:44 2022 +0200

    update text for add forge now email to forge admin

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1956/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1956/console

Harbormaster returned this revision to the author for changes because remote builds failed.Aug 5 2022, 2:08 PM
Harbormaster failed remote builds in B30655: Diff 29591!
anlambert added a subscriber: anlambert.Aug 8 2022, 11:50 AM

It looks like your eslint is not using the right configuration file so that's why the build failed.

The configuration file to use is assets/config/.eslintrc and is stored in swh-web repository.

If you are using vscode, you can install the eslint extension and add the following configuration in the workspace preferences:

"eslint.options": {
  "overrideConfigFile": "<path to swh-web>/assets/config/.eslintrc",
  "ignorePath": "<path to swh-web>/assets/config/.eslintignore"
 },
"editor.codeActionsOnSave": {
  "source.fixAll.eslint": true,
}
bchauvet updated this revision to Diff 29691.Aug 10 2022, 3:04 PM

fix eslint and rebase

swh-public-ci added a comment.Aug 10 2022, 3:23 PM

Build has FAILED

Patch application report for D8200 (id=29691)

Rebasing onto 46f0827408...

Current branch diff-target is up to date.
Changes applied before test
commit 0156894988dd0e63451aa7a551049924a6a4e99a
Author: Benoit Chauvet <contact@benoitchauvet.com>
Date:   Fri Aug 5 12:07:44 2022 +0200

    update text for add forge now email to forge admin

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1959/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1959/console

Harbormaster returned this revision to the author for changes because remote builds failed.Aug 10 2022, 3:23 PM
Harbormaster failed remote builds in B30744: Diff 29691!
bchauvet updated this revision to Diff 29692.Aug 10 2022, 3:32 PM

update text in cypress test

anlambert added inline comments.Aug 10 2022, 3:36 PM
cypress/e2e/add-forge-now-request-dashboard.cy.js
142

s/request/notification/ to fix cypress test

anlambert added a comment.Aug 10 2022, 3:36 PM

Also the yarn.lock file should be restored as it must be stored in the repository.

bchauvet updated this revision to Diff 29693.Aug 10 2022, 3:38 PM

updated email title in cypress file

bchauvet updated this revision to Diff 29695.Aug 10 2022, 3:49 PM
bchauvet marked an inline comment as done.

restored yarn.lock

swh-public-ci added a comment.Aug 10 2022, 3:54 PM

Build was aborted

Patch application report for D8200 (id=29692)

Rebasing onto 46f0827408...

Current branch diff-target is up to date.
Changes applied before test
commit 1cab4ef07b136b424d9f11fc41a3f5760e1fd4b4
Author: Benoit Chauvet <contact@benoitchauvet.com>
Date:   Fri Aug 5 12:07:44 2022 +0200

    update text for add forge now email to forge admin

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1960/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1960/console

Harbormaster failed remote builds in B30745: Diff 29692!Aug 10 2022, 3:54 PM
swh-public-ci added a comment.Aug 10 2022, 3:55 PM

Build was aborted

Patch application report for D8200 (id=29693)

Rebasing onto 46f0827408...

Current branch diff-target is up to date.
Changes applied before test
commit adb69cd724f1c64664b332287cdadc84cc7acd6c
Author: Benoit Chauvet <contact@benoitchauvet.com>
Date:   Fri Aug 5 12:07:44 2022 +0200

    update text for add forge now email to forge admin

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1961/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1961/console

Harbormaster failed remote builds in B30746: Diff 29693!Aug 10 2022, 3:55 PM
swh-public-ci added a comment.Aug 10 2022, 4:09 PM

Build is green

Patch application report for D8200 (id=29695)

Rebasing onto 46f0827408...

Current branch diff-target is up to date.
Changes applied before test
commit 16ba15e51ece4bada343fef3d73c7ffa93e38ff0
Author: Benoit Chauvet <contact@benoitchauvet.com>
Date:   Fri Aug 5 12:07:44 2022 +0200

    update text for add forge now email to forge admin

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1962/ for more details.

Harbormaster completed remote builds in B30748: Diff 29695.Aug 10 2022, 4:09 PM
bchauvet requested review of this revision.Aug 10 2022, 4:09 PM
anlambert accepted this revision.Aug 10 2022, 4:13 PM
This revision is now accepted and ready to land.Aug 10 2022, 4:13 PM
Closed by commit rDWAPPS16ba15e51ece: update text for add forge now email to forge admin (authored by bchauvet). · Explain WhyAug 10 2022, 4:14 PM
This revision was automatically updated to reflect the committed changes.
bchauvet added a commit: rDWAPPS16ba15e51ece: update text for add forge now email to forge admin.

Revision Contents
Changeset List

PathSize
assets/
src/
bundles/
add_forge/
10 lines
12 lines
cypress/
e2e/
52 lines

Diff 29591

View Options

assets/src/bundles/add_forge/forge-admin-email.ejs

Loading...
View Options

assets/src/bundles/add_forge/request-dashboard.js

Loading...
View Options

cypress/e2e/add-forge-now-request-dashboard.cy.js

Loading...
About · Developer information · Legal