Differential D8089

Provision thanos query node
ClosedPublic
Actions

Authored by ardumont on Jul 6 2022, 5:48 PM.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

System administrators

Maniphest Tasks

T4385: Federate prometheus instances through thanos

Commits

rSPRE0c3856d06d93: Provision thanos query node in the admin vlan

Summary

I'm not sure about the name though.
It's for exposing the thanos-query service.

Related to T4385

Test Plan

terraform plan happy

Diff Detail

Repository

rSPRE sysadm-provisioning

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 30286
Build 47349: arc lint + arc unit

Event Timeline

ardumont created this revision.Jul 6 2022, 5:48 PM

Herald added a reviewer: System administrators. · View Herald TranscriptJul 6 2022, 5:48 PM

ardumont requested review of this revision.Jul 6 2022, 5:48 PM

Harbormaster completed remote builds in B30284: Diff 29195.Jul 6 2022, 5:48 PM

Update reserved ip address

Harbormaster completed remote builds in B30285: Diff 29196.Jul 6 2022, 6:03 PM

ardumont edited the summary of this revision. (Show Details)Jul 6 2022, 6:03 PM

Move that node to the admin vlan

Harbormaster completed remote builds in B30286: Diff 29197.Jul 6 2022, 6:12 PM

vsellier requested changes to this revision.Jul 7 2022, 11:52 AM

vsellier added a subscriber: vsellier.

vsellier added inline comments.

proxmox/terraform/admin/admin.tf
190	154 is already taken ;)

This revision now requires changes to proceed.Jul 7 2022, 11:52 AM

I've no idea if the cpu/memory/disk spec are large enough or not, I didn't find the info on the thanos documentation

I've no idea if the cpu/memory/disk spec are large enough or not, I didn't find the info on the thanos documentation

same, i just re-used existing one. My trail of thought is that i'll see what happens when deployed and improved if it's no enough (or the opposite).

proxmox/terraform/admin/admin.tf
190	yes, right. I tend to prefer letting terraform spawn the vm by itself, then retrieve the id it elected so i'll do the same when i'll actually spawn it.

ardumont mentioned this in T4385: Federate prometheus instances through thanos.Jul 7 2022, 12:01 PM

Update with the right diff id

Harbormaster completed remote builds in B30303: Diff 29214.Jul 7 2022, 2:49 PM

vsellier accepted this revision.Jul 7 2022, 2:51 PM

This revision is now accepted and ready to land.Jul 7 2022, 2:51 PM

Closed by commit rSPRE0c3856d06d93: Provision thanos query node in the admin vlan (authored by ardumont). · Explain WhyJul 7 2022, 2:52 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rSPRE0c3856d06d93: Provision thanos query node in the admin vlan.

Revision Contents
Changeset List

Path

Size

proxmox/

terraform/

admin/

28 lines

Diff 29197

proxmox/terraform/admin/admin.tf

Loading...