codemeta: Use compact URIs
AbandonedPublicDraft
Actions

Authored by vlorentz on Jul 4 2022, 1:08 PM.

Details

Reviewers

None

Group Reviewers

Reviewers

Summary

This does not change the semantics of the produced documents, but makes
them shorter when they use many non-codemeta properties (eg. see
change to test_github.py)

However, this makes them longer when only using codemeta

Diff Detail

Repository

rDCIDX Metadata indexer

Branch

compact-context

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 30227
Build 47246: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 47245: arc lint + arc unit

Event Timeline

vlorentz created this revision.Jul 4 2022, 1:08 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJul 4 2022, 1:08 PM

vlorentz edited the summary of this revision. (Show Details)Jul 4 2022, 1:09 PM

vlorentz abandoned this revision.Jul 4 2022, 1:16 PM

Build was aborted

Patch application report for D8071 (id=29134)

Could not rebase; Attempt merge onto 61b22345e7...

Updating 61b2234..eea9993
Fast-forward
 swh/indexer/codemeta.py                            | 13 +++++-
 swh/indexer/metadata_dictionary/cff.py             |  6 +--
 swh/indexer/tests/metadata_dictionary/test_cff.py  |  7 +--
 .../tests/metadata_dictionary/test_codemeta.py     |  6 +--
 .../tests/metadata_dictionary/test_github.py       |  9 ++--
 .../tests/metadata_dictionary/test_maven.py        | 23 +++++-----
 swh/indexer/tests/metadata_dictionary/test_npm.py  | 23 +++++-----
 .../tests/metadata_dictionary/test_python.py       |  9 ++--
 swh/indexer/tests/metadata_dictionary/test_ruby.py | 13 +++---
 swh/indexer/tests/test_codemeta.py                 | 53 ++++++++++++----------
 swh/indexer/tests/test_metadata.py                 |  5 +-
 swh/indexer/tests/utils.py                         |  3 +-
 12 files changed, 96 insertions(+), 74 deletions(-)

Changes applied before test

commit eea9993701fecdd973b2ca72396be74abea2f1d0
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Jul 4 13:08:44 2022 +0200

    codemeta: Use compact URIs
    
    This does not change the semantics of the produced documents, but makes
    them shorter when they use many non-codemeta properties.
    
    However, this makes them longer when only using codemeta

commit d84d1a47c3fbfe6eff2afd26253382f9f3fd13e5
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Jul 4 13:03:17 2022 +0200

    cff: Remove redundant @context setting
    
    It is already set by _translate_dict itself.

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/320/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/320/console

Harbormaster failed remote builds in B30227: Diff 29134!Jul 4 2022, 1:20 PM

vlorentz mentioned this in D8073: Use compact URIs for ForgeFed and ActivityStreams.Jul 4 2022, 1:56 PM