Differential D8049

Crates loader, use **kwargs on task and loader initialisation instead of named args
ClosedPublic
Actions

Authored by franckbret on Jun 29 2022, 2:58 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDLDBASE50bde53da53b: Crates loader, use **kwargs on task and loader initialisation instead of

Summary

This fix an issue discovered while testing loader on docker environment,
error was (load_crates() got an unexpected keyword argument 'lister_name')

Related T4104

Diff Detail

Repository

rDLDBASE Generic VCS/Package Loader

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

franckbret created this revision.Jun 29 2022, 2:58 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJun 29 2022, 2:58 PM

Build is green

Patch application report for D8049 (id=29039)

Rebasing onto d627c2598a...

Current branch diff-target is up to date.

Changes applied before test

commit 50bde53da53b7fce9616da3f208831948700ce8e
Author: Franck Bret <franck.bret@octobus.net>
Date:   Wed Jun 29 14:49:27 2022 +0200

    Crates loader, use **kwargs on task and loader initialisation instead of
    named args
    
    This fix an issue discovered while testing loader on docker environment,
    error was (load_crates() got an unexpected keyword argument 'lister_name')
    
    Related T4104

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/809/ for more details.

Harbormaster completed remote builds in B30125: Diff 29039.Jun 29 2022, 3:01 PM

franckbret requested review of this revision.Jun 29 2022, 3:01 PM

franckbret mentioned this in T4104: Ingest crates.io (Rust).Jun 29 2022, 3:03 PM

ardumont accepted this revision.Jun 29 2022, 3:20 PM

This revision is now accepted and ready to land.Jun 29 2022, 3:20 PM

Closed by commit rDLDBASE50bde53da53b: Crates loader, use **kwargs on task and loader initialisation instead of (authored by franckbret). · Explain WhyJun 29 2022, 3:28 PM

This revision was automatically updated to reflect the committed changes.

franckbret added a commit: rDLDBASE50bde53da53b: Crates loader, use **kwargs on task and loader initialisation instead of.