Differential D8032

Refactoring: remove unnecessary code
ClosedPublic
Actions

Authored by jayeshv on Jun 24 2022, 12:20 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDGQL836eddb72ec8: Refactoring: remove unnecessary code

Summary

Drop the call function from base resolvers
Rename unused schema fields to use python convention
Improve doc strings

Diff Detail

Repository

rDGQL GraphQL API

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jayeshv created this revision.Jun 24 2022, 12:20 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJun 24 2022, 12:20 PM

Build is green

Patch application report for D8032 (id=28930)

Rebasing onto ce677e0bde...

Current branch diff-target is up to date.

Changes applied before test

commit 836eddb72ec8f6ea2d042355719623318de31422
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Fri Jun 24 10:54:20 2022 +0200

    Refactoring: remove unnecessary code
    
    - Drop the __call__ function from base resolvers
    - Rename unused schema fields to use python convention
    - Improve doc strings

See https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/71/ for more details.

Harbormaster completed remote builds in B30023: Diff 28930.Jun 24 2022, 12:22 PM

jayeshv requested review of this revision.Jun 24 2022, 12:22 PM

ardumont accepted this revision.Jun 24 2022, 2:35 PM

This revision is now accepted and ready to land.Jun 24 2022, 2:35 PM

Closed by commit rDGQL836eddb72ec8: Refactoring: remove unnecessary code (authored by jayeshv). · Explain WhyJun 24 2022, 2:37 PM

This revision was automatically updated to reflect the committed changes.

jayeshv added a commit: rDGQL836eddb72ec8: Refactoring: remove unnecessary code.