Page MenuHomeSoftware Heritage

cache: Don't return objstorage.add's return value, and add types
ClosedPublic

Authored by vlorentz on Wed, Jun 22, 11:17 AM.

Details

Summary

objstorage.add() will change/remove its return value in a future version,
and we do not use it in the vault anyway.

Diff Detail

Repository
rDVAU Software Heritage Vault
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D8016 (id=28881)

Rebasing onto 6436f0bb3a...

Current branch diff-target is up to date.
Changes applied before test
commit 8ac000b4e1cf7b2e4ec0484e5fa738817fd0b4f1
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Jun 22 11:16:57 2022 +0200

    cache: Don't return objstorage.add's return value, and add types
    
    objstorage.add() will change/remove its return value in a future version,
    and we do not use it in the vault anyway.

See https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/238/ for more details.

This revision is now accepted and ready to land.Wed, Jun 22, 11:30 AM