Differential D797

Initial structure of Docker images.
AbandonedPublic
Actions

Authored by vlorentz on Dec 10 2018, 4:06 PM.

Details

Reviewers

None

Group Reviewers

Reviewers

Summary

Creates Docker images in an order that makes it as fast as
possible to rebuild/re-run after a source code change.

Diff Detail

Repository

rCDFD Dockerfiles for developers

Branch

initial-structure

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 2966
Build 3785: arc lint + arc unit

Event Timeline

vlorentz created this revision.Dec 10 2018, 4:06 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptDec 10 2018, 4:06 PM

Harbormaster completed remote builds in B2965: Diff 2541.Dec 10 2018, 4:06 PM

rebase

Harbormaster completed remote builds in B2966: Diff 2542.Dec 10 2018, 4:11 PM

I'm a bit worried about this approach, as the goals of the design aren't well documented (the "define an architecture" part of T1426)

do we want to be able to test changes on several repos, rebuilding the image only once (i.e. replace the PYTHONPATH approach)?
do we want to use released versions allowing people to deploy a "tested" Software Heritage

I think we should make that very clear before we set out to write a lot of scaffolding around docker.

I'm also nervous that having the Dockerfiles outside of the repository they're used with is a good way to have them fall out of sync, but I guess that'd be a job for continuous integration.

vlorentz abandoned this revision.Dec 11 2018, 1:25 PM