Differential D7908

Refactor functional tests to use existing dataset
ClosedPublic
Actions

Authored by jayeshv on May 30 2022, 4:46 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDGQL00768c2e9eb2: Refactor functional tests to use existing dataset

Summary

re-use the dataset in swh-model

Diff Detail

Repository

rDGQL GraphQL API

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jayeshv created this revision.May 30 2022, 4:46 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMay 30 2022, 4:46 PM

Build is green

Patch application report for D7908 (id=28512)

Rebasing onto 6ee8e01f52...

Current branch diff-target is up to date.

Changes applied before test

commit 027d4ef3d84c19bd6e7c66212c2739370a9cd971
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Mon May 30 10:47:39 2022 +0200

    Refactor functional tests to use existing dataset
    
    re-use the dataset in swh-model

See https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/34/ for more details.

Harbormaster completed remote builds in B29602: Diff 28512.May 30 2022, 4:48 PM

jayeshv requested review of this revision.May 30 2022, 4:48 PM

lgtm

A couple of remarks/suggestions inline.

swh/graphql/tests/functional/test_origin_connection.py
39–68	I usually prefer using format for pattern like this, that allows to give some more meaning to the value we are replacing in the string.
swh/graphql/tests/functional/test_origin_node.py
46	same remark... etc...
swh/graphql/tests/functional/utils.py
9	What do you think about adding types? Even though that's test utilities, it might come in handy for future refactoring later.

This revision is now accepted and ready to land.May 31 2022, 2:15 PM

jayeshv added inline comments.May 31 2022, 2:20 PM

swh/graphql/tests/functional/utils.py
9	@ardumont Thanks. I will do that. In fact, type hints are missing in many modules and I have a ticket for adding those. T4261

Rebase and Review changes

Build is green

Patch application report for D7908 (id=28547)

Rebasing onto b312a60fad...

Current branch diff-target is up to date.

Changes applied before test

commit 00768c2e9eb2483925df4bed57dd4553840b045d
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Mon May 30 10:47:39 2022 +0200

    Refactor functional tests to use existing dataset
    
    re-use the dataset in swh-model

See https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/36/ for more details.

Harbormaster completed remote builds in B29633: Diff 28547.May 31 2022, 3:17 PM

jayeshv marked 2 inline comments as done.May 31 2022, 3:19 PM

Closed by commit rDGQL00768c2e9eb2: Refactor functional tests to use existing dataset (authored by jayeshv). · Explain WhyMay 31 2022, 3:19 PM

This revision was automatically updated to reflect the committed changes.

jayeshv added a commit: rDGQL00768c2e9eb2: Refactor functional tests to use existing dataset.