Differential D7880

Deal with git protocol url to canonicalize to https
ClosedPublic
Actions

Authored by ardumont on May 20 2022, 5:26 PM.

Details

Reviewers

None

Group Reviewers

Reviewers

Maniphest Tasks

T4232: Listers: Canonicalize listed github origins

Commits

rDCORE817c9e099c3b: Deal with git protocol url to canonicalize to https

Summary

This matches the actual api call with git:// urls which returns the html url (https).

Related to T4232

Diff Detail

Repository

rDCORE Foundations and core functionalities

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.May 20 2022, 5:26 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMay 20 2022, 5:26 PM

Build is green

Patch application report for D7880 (id=28436)

Rebasing onto cbcbf0102f...

Current branch diff-target is up to date.

Changes applied before test

commit 817c9e099c3bc330b865ce2f1c6eb587c703159c
Author: Antoine R. Dumont (@ardumont) <antoine.romain.dumont@gmail.com>
Date:   Fri May 20 17:24:57 2022 +0200

    Deal with git protocol url to canonicalize to https
    
    Related to T4232

See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/426/ for more details.

Harbormaster completed remote builds in B29527: Diff 28436.May 20 2022, 5:28 PM

ardumont requested review of this revision.May 20 2022, 5:28 PM

ardumont added inline comments.May 20 2022, 5:30 PM

swh/core/github/tests/test_github_utils.py
22	that code was in runtime side for no good reason as it's only used by test.

ardumont mentioned this in T4232: Listers: Canonicalize listed github origins.May 20 2022, 5:48 PM

ardumont added a child revision: D7879: Adapt maven lister to list canonical gh urls if any.May 20 2022, 5:59 PM

This revision was not accepted when it landed; it landed in state Needs Review.May 20 2022, 6:17 PM

Closed by commit rDCORE817c9e099c3b: Deal with git protocol url to canonicalize to https (authored by ardumont). · Explain Why

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDCORE817c9e099c3b: Deal with git protocol url to canonicalize to https.

Revision Contents
Changeset List

Path

Size

swh/

core/

github/

tests/

test_github_utils.py

87 lines

utils.py

7 lines

Diff 28440

View Options

swh/core/github/tests/test_github_utils.py