Differential D7863

Use swhid instead of SWHID in the schema fields
ClosedPublic
Actions

Authored by jayeshv on May 19 2022, 11:50 AM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Commits

rDGQLd5010fd75f6f: Use swhid instead of SWHID in the schema fields

Summary

Related to: T4261

Diff Detail

Repository

rDGQL GraphQL API

Branch

swhid-small

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 29480
Build 46067: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 46066: arc lint + arc unit

Event Timeline

jayeshv created this revision.May 19 2022, 11:50 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptMay 19 2022, 11:50 AM

Build is green

Patch application report for D7863 (id=28384)

Rebasing onto 783a4d3081...

Current branch diff-target is up to date.

Changes applied before test

commit 4ca1df9b5d9c07d3c56246a9abeee3f0b55352bf
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Thu May 19 11:34:39 2022 +0200

    Use swhid instead of SWHID in the schema fields
    
    Related to: T4261

See https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/22/ for more details.

Harbormaster completed remote builds in B29480: Diff 28384.May 19 2022, 11:53 AM

jayeshv requested review of this revision.May 19 2022, 11:53 AM

You must keep SWHID in uppercase in docstrings (see documentation).

This revision now requires changes to proceed.May 19 2022, 12:00 PM

Addressing review comment; change swhid to SWHID in doc strings

Build is green

Patch application report for D7863 (id=28385)

Rebasing onto 783a4d3081...

Current branch diff-target is up to date.

Changes applied before test

commit d5010fd75f6f0355eb695960f6356acb1b95ce17
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Thu May 19 11:34:39 2022 +0200

    Use swhid instead of SWHID in the schema fields
    
    Related to: T4261

See https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/23/ for more details.

Harbormaster completed remote builds in B29481: Diff 28385.May 19 2022, 12:16 PM

anlambert accepted this revision.May 19 2022, 12:31 PM

This revision is now accepted and ready to land.May 19 2022, 12:31 PM

Closed by commit rDGQLd5010fd75f6f: Use swhid instead of SWHID in the schema fields (authored by jayeshv). · Explain WhyMay 19 2022, 12:34 PM

This revision was automatically updated to reflect the committed changes.

jayeshv added a commit: rDGQLd5010fd75f6f: Use swhid instead of SWHID in the schema fields.