broker.
ClosedPublic
Actions

Authored by vlorentz on Dec 3 2018, 2:45 PM.

Details

Reviewers

Group Reviewers

Commits

rDSCH46b2ba61e42c: Fallback for get_queue_stats() when using memory:// broker.
rDSCH0f7728690533: Fallback for get_queue_stats() when using memory:// broker.

Summary

When running tests, RabbitMQ is not used, so get_queue_stats()
does not work.

We did not notice this issue before because pytest skipped
importing modules that define tasks with a queue, so this
function was never actually called while running tests.

Diff Detail

Repository

rDSCH Scheduling utilities

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Dec 3 2018, 2:45 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptDec 3 2018, 2:45 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSCH/job/tox/29/ for more details.

Harbormaster completed remote builds in B2793: Diff 2397.Dec 3 2018, 2:48 PM

Thanks.

Note: We will need to start adding tests in there (runner & listener).

This revision is now accepted and ready to land.Dec 3 2018, 3:53 PM

Closed by commit rDSCH0f7728690533: Fallback for get_queue_stats() when using memory:// broker. (authored by vlorentz). · Explain WhyDec 3 2018, 3:53 PM

This revision was automatically updated to reflect the committed changes.

ardumont mentioned this in D766: indexer: Fix ever-lasting integration test (jenkins included).Dec 4 2018, 12:24 PM

Revision Contents
Changeset List

Path

Size

swh/

scheduler/

celery_backend/

config.py

10 lines

runner.py

8 lines

Diff 2398

View Options

swh/scheduler/celery_backend/config.py