Page MenuHomeSoftware Heritage
Differential D757

Fix fixmes
ClosedPublic
Actions

Authored by ardumont on Nov 30 2018, 4:08 PM.

Details

Reviewers
vlorentz
Group Reviewers
Reviewers
Commits
rDCIDX0291a35b640e: indexer: Fix FIXME about names 2/3
rDCIDXcbb8842e61bb: tests: Remove unneeded steps
rDCIDX7bcde56e1ed6: indexer: Fix FIXME about names 3/3
rDCIDXc2da3e8ce318: indexer: Fix FIXME about names
Summary
  • indexer: Fix FIXME about names
  • indexer: Fix FIXME about names 2/3
  • indexer: Fix FIXME about names 3/3
  • tests: Remove unneeded steps
Test Plan

tox

Diff Detail

Repository
rDCIDX Metadata indexer
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Nov 30 2018, 4:08 PM
swh-public-ci added a subscriber: swh-public-ci.Nov 30 2018, 4:11 PM

Build is green
See https://jenkins.softwareheritage.org/job/DCIDX/job/tox/100/ for more details.

Harbormaster completed remote builds in B2754: Diff 2373.Nov 30 2018, 4:11 PM
vlorentz accepted this revision.Nov 30 2018, 4:45 PM

Should we rename task classes as well?

This revision is now accepted and ready to land.Nov 30 2018, 4:45 PM
Closed by commit rDCIDXc2da3e8ce318: indexer: Fix FIXME about names (authored by ardumont). · Explain WhyNov 30 2018, 5:09 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
swh/
indexer/
9 lines
4 lines
tests/
4 lines
2 lines

Diff 2380

View Options

swh/indexer/mimetype.py

Loading...
View Options

swh/indexer/tasks.py

Loading...
View Options

swh/indexer/tests/test_mimetype.py

Loading...
View Options

swh/indexer/tests/test_utils.py

Loading...
About · Developer information · Legal