Page MenuHomeSoftware Heritage

swh.objstorage: Align config 'cls' key class for memory objstorage
ClosedPublic

Authored by ardumont on Wed, Nov 28, 5:49 PM.

Details

Summary
  • storage uses 'memory'
  • indexer-storage starts as well

Might as well unify.

Did not see any use yet.

Indexers might start using this soon.

Test Plan

tox

Diff Detail

Repository
rDOBJS Object storage
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Wed, Nov 28, 5:49 PM
olasd accepted this revision.Wed, Nov 28, 5:52 PM
olasd added a subscriber: olasd.

You could update swh/storage/tests/test_in_memory.py to use get_objstorage() with the class argument, that way it'd have at least one user ;)

This revision is now accepted and ready to land.Wed, Nov 28, 5:52 PM
ardumont updated this revision to Diff 2286.Wed, Nov 28, 5:59 PM

Use get_objstorage method to instantiate the memory objstorage

You could update swh/storage/tests/test_in_memory.py to use get_objstorage() with the class argument, that way it'd have at least one user ;)

Good idea!

This revision was automatically updated to reflect the committed changes.