Page MenuHomeSoftware Heritage

revision metadata indexer: Fix multiple errors
ClosedPublic

Authored by ardumont on Mon, Nov 26, 7:26 PM.

Details

Summary

This diffs fixes quite some initialization issues and other errors
(variable initialization, logging format exception) in the revision
metadata indexer.

Note for later.
We need to simplify the initialization of the indexers.
This has become far too tedious in its current state.

For this, I think we could:

  • remove the prepare() indirection
  • and use bare init (which is more pythonic and expected)
  • to override the configuration in tests, override the parse_config_file (coming from the SWHConfig instead of overriding prepare)
Test Plan

tox

Diff Detail

Repository
rDCIDX Object indexer
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Mon, Nov 26, 7:26 PM
vlorentz accepted this revision.Mon, Nov 26, 7:29 PM
This revision is now accepted and ready to land.Mon, Nov 26, 7:29 PM
This revision was automatically updated to reflect the committed changes.