Page MenuHomeSoftware Heritage

revision metadata indexer: Fix multiple errors

Authored by ardumont on Nov 26 2018, 7:26 PM.



This diffs fixes quite some initialization issues and other errors
(variable initialization, logging format exception) in the revision
metadata indexer.

Note for later.
We need to simplify the initialization of the indexers.
This has become far too tedious in its current state.

For this, I think we could:

  • remove the prepare() indirection
  • and use bare init (which is more pythonic and expected)
  • to override the configuration in tests, override the parse_config_file (coming from the SWHConfig instead of overriding prepare)
Test Plan


Diff Detail

rDCIDX Object indexer
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Nov 26 2018, 7:26 PM
vlorentz accepted this revision.Nov 26 2018, 7:29 PM
This revision is now accepted and ready to land.Nov 26 2018, 7:29 PM
This revision was automatically updated to reflect the committed changes.