Page MenuHomeSoftware Heritage

Split uploading to PyPI into a separate job
ClosedPublic

Authored by olasd on Nov 26 2018, 5:25 PM.

Details

Summary

This allows us to trigger PyPI uploads from the incoming tag job, rather than
using a crude "this commit matches a tag" workaround.

Test Plan

tox looks happy; needs some testing on actual jenkins

Diff Detail

Repository
rCJSWH Jenkins jobs
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

olasd created this revision.Nov 26 2018, 5:25 PM
olasd updated this revision to Diff 2247.Nov 26 2018, 6:04 PM
  • Rename PYPI parameter to PYPI_HOST and remove PYPI_UPLOAD parameter
olasd updated this revision to Diff 2252.Nov 27 2018, 1:23 AM
  • Make sure the LASTV shell script actually works
olasd updated this revision to Diff 2253.Nov 27 2018, 1:40 AM

Feedback from tests on the live jenkins instance

this looks a very nice improvement. LGTM, let jenkins tells us if I'm right.

jobs/templates/swh-pypi.yaml
34

Why not SKIP instead/also?

douardda accepted this revision.Nov 27 2018, 12:00 PM
This revision is now accepted and ready to land.Nov 27 2018, 12:00 PM
olasd marked an inline comment as done.Nov 27 2018, 12:03 PM
olasd added inline comments.
jobs/templates/swh-pypi.yaml
34

That's a fair point; it would allow us to skip waiting a whole *two* minutes to push an upload *right now* :-)

I've also noticed that the FORCE_UPLOAD logic is useless because of PyPI completely preventing you from reusing a filename, even if you delete it before: https://pypi.org/help/#file-name-reuse

olasd updated this revision to Diff 2262.Nov 27 2018, 4:14 PM
olasd marked an inline comment as done.
  • Add an option to skip running the tests when publishing to PyPI
This revision was automatically updated to reflect the committed changes.