Paths

Table of Contentst

Differential D70

web ui search: fix invalid sha1s being searched anyway
ClosedPublic
Actions

Authored by jbertran on Jun 28 2016, 4:41 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Maniphest Tasks

T467: Validate the text input in the search page

Commits

R65:e5f381132c8b: web ui search: fix invalid sha1s being searched anyway
R65:c34790145fbf: filedrop.js: fix tabulation and docstring
rDWAPPSe5f381132c8b: web ui search: fix invalid sha1s being searched anyway
rDWAPPSc34790145fbf: filedrop.js: fix tabulation and docstring

Summary

The text input is now validated before search submission

Diff Detail

Repository

rDWAPPS Web applications

Branch

T467

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 268
Build 395: Software Heritage Python tests
Build 394: arc lint + arc unit

Event Timeline

jbertran updated this revision to Diff 236.Jun 28 2016, 4:41 PM

jbertran added a task: T467: Validate the text input in the search page.

jbertran retitled this revision from to web ui search: fix invalid sha1s being searched anyway.

jbertran updated this object.

jbertran edited the test plan for this revision. (Show Details)

Herald added a reviewer: Reviewers. · View Herald TranscriptJun 28 2016, 4:41 PM

ardumont added a subscriber: ardumont.Jun 28 2016, 4:44 PM

ardumont added inline comments.

swh/web/ui/static/js/filedrop.js
105	`submission`
111	searchForm is not a parameter of this function, at least, not that i can see ^^
114	The tabulation/spaces seems messed up.

filedrop.js: fix tabulation and docstring

Herald edited edge metadata. · View Herald TranscriptJun 28 2016, 4:52 PM

ardumont accepted this revision.Jun 28 2016, 4:53 PM

ardumont added a reviewer: ardumont.

This revision is now accepted and ready to land.Jun 28 2016, 4:53 PM

Closed by commit rDWAPPSe5f381132c8b: web ui search: fix invalid sha1s being searched anyway (authored by jbertran). · Explain WhyJun 28 2016, 4:58 PM

This revision was automatically updated to reflect the committed changes.

jbertran mentioned this in T467: Validate the text input in the search page.Jun 28 2016, 4:58 PM

Revision Contents
Changeset List

Path

Size

swh/

web/

ui/

static/

js/

filedrop.js

53 lines

templates/

upload_and_search.html

12 lines

Diff 236

View Options

swh/web/ui/static/js/filedrop.js