Paths

Table of Contentst

Differential D7049

weekly-planning: Use curl instead of httpie
ClosedPublic
Actions

Authored by ardumont on Jan 31 2022, 12:32 PM.

Details

Reviewers

vsellier

Group Reviewers

System administrators

Commits

rSPSITE2e63ad54d946: weekly-planning: Use curl instead of httpie

Summary

http is writing file on disk and the 'nobody' user is not allowed to do that. curl is
fine without the need to write anything.

Related to P1270

Test Plan

Executing on pergamon as user nobody the following works (vs the original which failed,
see paste)

Diff Detail

Repository

rSPSITE puppet-swh-site

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Jan 31 2022, 12:32 PM

Herald added a reviewer: System administrators. · View Herald TranscriptJan 31 2022, 12:32 PM

Harbormaster completed remote builds in B26392: Diff 25561.Jan 31 2022, 12:32 PM

ardumont requested review of this revision.Jan 31 2022, 12:32 PM

ardumont added inline comments.Jan 31 2022, 12:32 PM

site-modules/profile/files/weekly_planning_bot/weekly-planning-bot
6	well, no! ;)
6	keep the old dest.

Fix dest

Harbormaster completed remote builds in B26393: Diff 25562.Jan 31 2022, 12:34 PM

site-modules/profile/files/weekly_planning_bot/weekly-planning-bot
16–17	Any reason to use `--data-binary` instead of `--data` ?

This revision is now accepted and ready to land.Jan 31 2022, 12:37 PM

ardumont added inline comments.Jan 31 2022, 12:39 PM

site-modules/profile/files/weekly_planning_bot/weekly-planning-bot
16–17	my attempt failed with --data iirc. That does some more conversion we don't need here iirc (from the manpage).

olasd added a subscriber: olasd.Jan 31 2022, 12:41 PM

olasd added inline comments.

site-modules/profile/files/weekly_planning_bot/weekly-planning-bot
2	`-x` is probably not needed now that the debugging happened.

ardumont added inline comments.Jan 31 2022, 3:17 PM

site-modules/profile/files/weekly_planning_bot/weekly-planning-bot
2	right!

Drop -x
rebase

Harbormaster completed remote builds in B26395: Diff 25565.Jan 31 2022, 3:17 PM

Closed by commit rSPSITE2e63ad54d946: weekly-planning: Use curl instead of httpie (authored by ardumont). · Explain WhyJan 31 2022, 4:32 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rSPSITE2e63ad54d946: weekly-planning: Use curl instead of httpie.

Revision Contents
Changeset List

Path

Size

site-modules/

profile/

files/

weekly_planning_bot/

weekly-planning-bot

8 lines

manifests/

weekly_planning_bot.pp

2 lines

Diff 25568

View Options

site-modules/profile/files/weekly_planning_bot/weekly-planning-bot